Closed Bug 1710257 Opened 3 years ago Closed 3 years ago

clang-cl unknown argument -fPIC warning

Categories

(Thunderbird :: Build Config, defect)

defect

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: rjl, Assigned: rjl)

References

(Regression)

Details

Attachments

(2 files)

Warning appears multiple times when compiling for Windows:
clang-12: warning: unknown argument ignored in clang-cl: '-fPIC' [-Wunknown-argument]

Started with:
https://hg.mozilla.org/comm-central/rev/61ebefcbdd36

That patch does address the issue, it adds -fPIC way too broadly.

-fPIC was only missing when compiling librnp, so that's the only place it needs to be added. rnpdefs.mozbuild is included by all of the dependencies of librnp, so that's the only place it needs to be added. It's addition also needs to be limited in scope to builds targeting Linux.

Assignee: nobody → rob
Status: NEW → ASSIGNED

Need to backout the commit from bug 1699386 before applying.

Target Milestone: --- → 90 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/818e555c0dc5
[linux] Build librnp and dependencies with -fPIC. r=justdave

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

The required backout of bug 1699386 (comment 2) didn't happen when this landed, so we still have these compiler warnings happening on the Windows builds.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch 44968.patchSplinter Review

Backout of bug 1699386 to fix extraneous clang-cl unknown argument -fPIC warnings.

Attachment #9221590 - Flags: review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f00dd5f18f0a
Back out changeset 61ebefcbdd36 (bug 1699386) due to compiler warnings on Windows. r=backout a=rjl

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: