Closed Bug 1710269 Opened 1 month ago Closed 1 month ago

[widget.macos.respect-system-appearance] "Clear Recent History..." window is not completely readable in Dark Mode

Categories

(Core :: Widget: Cocoa, defect, P2)

Desktop
macOS
defect
Points:
1

Tracking

()

RESOLVED FIXED
90 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Status
firefox90 --- fixed

People

(Reporter: mehmet.sahin, Assigned: harry, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Attached image Screenshot.png

Nightly 90.0a1 (2021-05-08) (64-Bit)
macOS 11.3.1

1.) Enable System Dark Mode
2.) Enable widget.macos.respect-system-appearance
3.) Select Mac Menu Bar -> History -> "Clear Recent History..."
4.) Change in the Popup the "Time range to clear" to "Everything"

Actual: The background of "All selected items will be cleared.
This action cannot be undone." is white, so that the white text is not readable.

Expected: The background of "All selected items will be cleared.
This action cannot be undone." should be dark, so that the white text is readable.

This is only an issue in Dark Mode.

A screenshot is attached.

Thanks.

Blocks: 1623686
OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Assignee: nobody → htwyford
Severity: -- → S3
Status: NEW → ASSIGNED
Iteration: --- → 90.2 - May 3 - May 16
Points: --- → 1
Priority: -- → P2

The sanitize window is the only place we use these colors on macOS: https://searchfox.org/mozilla-central/search?q=Window&path=.css&case=true&regexp=false. They're also used in toolkit/themes/shared/notification.css, but we override the notification API with macOS native notifications.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8c4ab91bbbf
Use the correct system colors for Window/WindowFrame on macOS. r=mac-reviewers,mstange
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Thanks for fixing this issue. I noticed that there is very bright border around the box. I would expect a more grey color? Maybe this could be related to Bug 1710583? Thanks for checking :)

Flags: qe-verify+

Reproduced the issue with Firefox 90.0a1 (20210508095613) on macOS 11.3.
The text is now readable with Firefox 90.0b4 (20210606185718) on macOS 11.3. Also as stated above a bright border color can be seen surrounding the box. Harry do you think it's related to bug 1710583, or a new issue should be filled? Thank you!

Flags: needinfo?(htwyford)
You need to log in before you can comment on or make changes to this bug.