171027 - Remove deprecated API from test examples

Status: RESOLVED FIXED

(JSS Graveyard :: Sample Code, defect)

Description

[glen beasley]

Remove deprecated API from test examples

Comment 1

[glen beasley]

Attachment: Ussing JSS JCA provider for key generation and signing

main: jss library loaded
Provider 0: Mozilla-JSS
Provider 1: SUN
Provider 2: SunJSSE
Provider 3: SunRsaSign
Provider 4: SunJCE
Provider 5: SunJGSS
Enter password for Internal Key Storage Token
***
The provider used to Generate the Keys was Mozilla-JSS
provider info Provides Signature, Message Digesting, and RNG
Created a signing context
The provider used to for the signer MD5/RSA was Mozilla-JSS
initialized the signing operation
updated signature with data
Successfully signed!
initialized verification
updated verification with data
Signature Verified Successfully!

Comment 2

[Jamie Nicolson]

Looks good.
r=nicolson

Comment 3

[glen beasley]

Attachment: comment changed to rename HCL to NSS

Comment 4

[glen beasley]

Attachment: removed deprecated api from all tests that are run by all.pl

removed the deprecated api from the tests that are run by all.pl
except for SigTest.java because JCASigTest is it's replacement. 

DigestTest.java tests SHA1, MD2, MD5, SHA256,SHA384, and SHA512

Created HMACTest.java and added the HMACTest to all.pl

Removed Deprecated api from KeyFactoryTest, and added the test
to all.pl

Comment 5

[Sandeep Konchady]

Comment on attachment 198544 [details] [diff] [review]
removed deprecated api from all tests that are run by all.pl

Reviewed the code.  The changes look fine.

Comment 6

[glen beasley]

Checking in DigestTest.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/DigestTest.java,v  <-- 
DigestTest.java
new revision: 1.10; previous revision: 1.9
done
Checking in GenerateTestCert.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/GenerateTestCert.java,v  <--
 GenerateTestCert.java
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/security/jss/org/mozilla/jss/tests/HMACTest.java,v
done
Checking in HMACTest.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/HMACTest.java,v  <-- 
HMACTest.java
initial revision: 1.1
done
Checking in JCASigTest.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/JCASigTest.java,v  <-- 
JCASigTest.java
new revision: 1.11; previous revision: 1.10
done
Checking in JSSPackageTest.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/JSSPackageTest.java,v  <-- 
JSSPackageTest.java
new revision: 1.3; previous revision: 1.2
done
Checking in KeyFactoryTest.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/KeyFactoryTest.java,v  <-- 
KeyFactoryTest.java
new revision: 1.3; previous revision: 1.2
done
Checking in ListCACerts.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/ListCACerts.java,v  <-- 
ListCACerts.java
new revision: 1.3; previous revision: 1.2
done
Checking in SSLClientAuth.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/SSLClientAuth.java,v  <-- 
SSLClientAuth.java
new revision: 1.2; previous revision: 1.1
done
Checking in SetupDBs.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/SetupDBs.java,v  <-- 
SetupDBs.java
new revision: 1.4; previous revision: 1.3
done
Checking in SigTest.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/SigTest.java,v  <-- 
SigTest.java
new revision: 1.5; previous revision: 1.4
done
Checking in TestKeyGen.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/TestKeyGen.java,v  <-- 
TestKeyGen.java
new revision: 1.7; previous revision: 1.6
done
Checking in TestSDR.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/TestSDR.java,v  <-- 
TestSDR.java
new revision: 1.3; previous revision: 1.2
done
Checking in all.pl;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/all.pl,v  <--  all.pl
new revision: 1.24; previous revision: 1.23
done

note there are still some files that have deprecated code, but
they are not envoked as tests by all.pl; these files need to be checked 
and first the deprecated code needs to be removed, and then test
should be added to all.pl.