Closed Bug 1710317 Opened 3 years ago Closed 3 years ago

Pen eraser input emits pointer events with .button=0 on Windows

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

x86_64
Windows 10
defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

https://searchfox.org/mozilla-central/source/widget/windows/nsWindow.cpp#8675

There is no check for erasers. This is not a blocker for bug 1707080 since it's already broken without it.

MOZ_SOURCE_ERASER should be removed since it has no use and Pointer Events spec considers erasers as pens.

Severity: -- → S3
Priority: -- → P3
Assignee: nobody → krosylight
Status: NEW → ASSIGNED

It's not ideal to have mButton[s] only to pass them to PointerEvent, but it's required anyway.

Depends on D115508

Attachment #9222657 - Attachment description: Bug 1710317 - Part 2: Add mButton[s] to WidgetTouchEvent r=aklotz → Bug 1710317 - Part 2: Add mButton[s] to WidgetTouchEvent r=aklotz,edgar
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d16301a3675
Part 1: Add MouseButton::eEraser r=aklotz,edgar
https://hg.mozilla.org/integration/autoland/rev/d92899c7f5cc
Part 2: Add mButton[s] to WidgetTouchEvent r=aklotz,edgar
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Regressions: 1725416
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: