Closed Bug 1710328 Opened 2 years ago Closed 2 years ago

Reload button background 1px lower than other toolbar buttons

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
Firefox 89
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: sam, Assigned: sam)

References

Details

Attachments

(2 files)

toolbar.png
18.91 KB, image/png
Details
Bug 1710328 - Align reload icon without shifting background r?#desktop-theme-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Attached image toolbar.png —

Since bug 1708882, the hover/pressed background color of the reload button in the toolbar is 1px lower than other toolbar icons. The attached screenshot shows the hovered forward button next to the hovered reload button, where you can see the backgrounds are not aligned.

It looks like the intention of bug 1708882 was to lower the position of the icon, but it resulted in also lowering the background, which I do not believe was intentional.

Note that while the attached screenshot is from macOS with compact density, the issue reproduces with normal density and on other operating systems.

Managed to reproduce this issue on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04.

Status: UNCONFIRMED → NEW
status-firefox89: --- → affected
Ever confirmed: true
Version: Firefox 90 → Firefox 89
Assignee: nobody → sam
Status: NEW → ASSIGNED

Hi Harry, thanks for reviewing my patch! Would you be able to land it for me, as I don't believe I have access to do so?

Flags: needinfo?(htwyford)

Landed. Thanks for the reminder.

Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6b99c54fc73
Align reload icon without shifting background r=desktop-theme-reviewers,harry

https://hg.mozilla.org/mozilla-central/rev/c6b99c54fc73

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Regressions: 1722655
Depends on: 1708882
You need to log in before you can comment on or make changes to this bug.