Closed Bug 1710334 Opened 3 years ago Closed 3 years ago

"Try Again" button of about:netError appears above error message

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This has annoyed me for an age and I finally decided to find out why it happens.

In about:netError, if autofocus is applied to the Try Again button, it is removed from the DOM and reinserted (to make autofocus work apparently, I don't know anything about that). But it's inserted as the first node of the parent element, not where it was before removal. This used to work but was changed by bug 1496524.

I should've looked up the right component before filing. :-/

Component: Networking → DOM: Navigation

Reverses a slight change in logic introduced in bug 1496524.
Also tidies up some really badly formatted comments.

Severity: -- → S3
Priority: -- → P3
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/integration/autoland/rev/fce39bf3b222
Fix misplacement of about:netError "Try Again" button. r=ckerschb,johannh
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: