1710415 - Texts of Themes popup are barely readable on mouseover when system theme is light and Firefox theme is dark

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Strangiato]

Attachment: 2021-05-10 09-31-43.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

1. use a linux distribution with Gnome or KDE Plasma desktop environments
2. make sure a light GTK theme is set in the settings of your desktop environment
3. open Firefox and enable its dark theme
4. open Themes popup in Customize Firefox page and hover over its options

Actual results:

Options are barely readable on mouseover.
Please watch the attached screen recording.

Expected results:

better readability on mouseover

Comment 1

[Strangiato]

This bug does not occur when both GTK theme set in DE settings and Firefox theme are dark.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1710415 - Fix customizemode toolbarbutton styles to not use widget colors. r=dao,Gijs

We're suppressing native appearance, so we should also suppress the
native color.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70979067bc56
Fix customizemode toolbarbutton styles to not use widget colors. r=Gijs

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 70979067bc56 (Bug 1710415) for causing failures in browser_ext_themes_findbar.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=YllrAUoBR4aK3oTDPrLjtg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=70979067bc56a840e0cdeff58d39ce749595aec3

Log: https://treeherder.mozilla.org/logviewer?job_id=339329686&repo=autoland&lineNumber=2448

Backout: https://hg.mozilla.org/integration/autoland/rev/78a802a3ff703e764da8471582d7c2a2725e15e4

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1710415 - Fix browser_ext_themes_findbar.js with proton. r=Gijs

The border colors were the same because the
toolbarbutton[disabled="true"] rule was overriding the color. With a
setup like comment 0's these buttons also show really low contrast, and
my patch fixes that. The findbar toolbarbuttons don't have borders in
proton, so testing them seems not useful?

Depends on D114745

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13654aaf9556
Fix customizemode toolbarbutton styles to not use widget colors. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/562a7a1563c3
Fix browser_ext_themes_findbar.js with proton. r=Gijs

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/13654aaf9556
https://hg.mozilla.org/mozilla-central/rev/562a7a1563c3