1710432 - Windows 10 custom context menu styling's rounded corners do not look well-rounded

Status: NEW

(Firefox :: Menus, defect, P3)

Description

[Andronachi Marian]

Attachment: Images.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36

Actual results:

1. The context menu rounded corner not looks rounded. The edge pixels looks too sharp.
2. The main menu rounded corner looks too blurry to me.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Negritas Sergiu, Desktop QA]

Hello I have tried to reproduce this issue using Firefox 87.0 on Ubuntu 20 but unfortunately I wasn't able to reproduce it.
Could you please answer the following questions in order to further investigate this issue:

1. Does this issue happen with a new profile? Here is a link on how to create a new profile: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Are you using add-ons? If so could you please list them?
3. Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
4. On what resolution are you encountering this issue?
5. On what GPU are you encountering this issue(GPU model and driver used)?

Thank you!

Comment 3

[Andronachi Marian]

Attachment: PcaAW1eSbO.mp4

1. Why you testing it on Ubuntu if I submit it for Windows?
2. What that should to with anything... But Yes
3. Yes, and has more bugs than 87
4. What this has anything to do with it? 1920x1080 Native 100% Scale
5. What this has anything to do with it? Intel HD 4600 - 20.19.15.4549

Comment 4

[Andronachi Marian]

The video is from other Bug. I was get 2 emails and tangled them, sorry.

Comment 5

[Andronachi Marian]

2. No on Nightly, is just for testing
3. Is form other issue. But is on the latest Nightly

Comment 6

[Negritas Sergiu, Desktop QA]

Hello Andronachi! Thank you for your reply! I have managed to reproduce the issue on Windows 10 with Firefox Nightly 90.0a1(2021-05-12) and 89.0b11. I would like to mention that this issue also occurs on Ubuntu and MacOS 10.15 as well but it's very hard to spot at the first look.

I will add a component to this issue in order to get the developers involved, if it's not the right component please feel free to change it to an appropriate one.

Thank you!

Comment 7

[:Gijs (he/him)]

Attachment: Proton-ContextMenu.png

First image from attachment 9221132 [details]

Comment 8

[:Gijs (he/him)]

Attachment: Proton-MainMenu.png

Second image from attachment 9221132 [details]

Reporter: for future reference, please upload images individually rather than in archives, as it makes them much easier to see instead of having to download attachments manually, un-archiving them, etc.

Comment 9

[:Gijs (he/him)]

I genuinely can't tell what the issue is from these screenshots. The border radius on the context menu is meant to be 4px ( https://searchfox.org/mozilla-central/rev/2bc4e5cdf669cc9de3ed98e38be3e50a27b25332/toolkit/themes/windows/global/popup.css#36 ) so I don't know why you're comparing it with 5px. For the main menu, it looks like the border color in the CSS example and the menu are different, so again they can't be compared directly. The corner rounding on the context menu on Windows has some known issues, which is bug 1705254 , but those are around the bottom right-hand corner, so I don't know what issue you're seeing at the top but I can't see it in the blown-up screenshot (that goes for both the hamburger menu and the context menu).

Can you attach normal resolution screenshots and describe in more detail what you believe is wrong, or how you think it should be fixed?

Comment 10

[Andronachi Marian]

Attachment: border.png

Because the 4px looks like this. With no box shadow and the corners still not looking the same.
Maybe that bug has something to do with this. But still the pixels are too full on opacity and way to different from the CSS.

Comment 11

[Andronachi Marian]

On white background is not too much. But on dark background is really noticeable to me.

Comment 12

[Andronachi Marian]

Attachment: TelegramMenu.png

This is how the telegram menu are the same as 4px with CSS one.
And how should be.

Comment 13

[:Gijs (he/him)]

Emilio, can you provide some context about what would cause the rendering difference here, and if there's anything we can do about it? I suspect that because the menu is not in the same document as the background, achieving the same rendering may not be possible, but perhaps I'm missing something obvious...

Comment 14

[Andronachi Marian]

Attachment: TelegramCorners.png

Not really only on dark. But overall. Pixels should be the same if is on white or dark.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

This is probably more of a question for WebRender folks, but yeah, afaict antialiasing across windows (the browser popup is really a different window) is probably pretty hard.