1710456 - [wpt-sync] Sync PR 28943 - Reland "[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells"

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28943 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28943
Details from upstream follow.

b'Ian Kilpatrick <[e-mail]>' wrote:

Reland "[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells"

This is a reland of 75216ac41d2da077f3ae3a0ca992ee3e03a937a8

This was reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/2882605

"Reason for revert: Suspected to cause layout test failure on mac11"

However these were pre-existing layout test failures, and were present
on the mac11 bot after reverting, see:
https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests/668

Original change's description:

[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells

Alignment typically does affect the static-position of any
OOF-positioned children inside of a table-cell. However when we are
baseline-aligned, we should only apply the adjustment if we have
inflow children.

This doesn't shift the OOF-positioned children if we have no inflow
children.

Bug: 1206654
Change-Id: I54e80831148407797354157d2c0d19afbb2a7858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880809
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Aleks Totic \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#880652}

Bug: 1206654
Change-Id: Ic232f57b8feba0112693385bb2ca90d7cc8164ba

Reviewed-on: https://chromium-review.googlesource.com/2883187
WPT-Export-Revision: 8af346aa9650c6eade8724e6e5f1c46ef7bf0505

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e0a733f555091ae99a785414eadce3a7ea7be2f

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c27702f1d80
[wpt PR 28943] - Reland "[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3c27702f1d80