1710495 - Remove unused args from ReportInNotObjectError

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P5)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

ReportInNotObjectError has two args, lindex and rindex that aren't used and should be removed.

Prerequisites

Before getting started, you'll want to

• Have a checkout of the Firefox source code
• Make sure you can build SpiderMonkey
• Understand the basics of using Mercurial
• Understand how to submit a patch
• Read this walkthrough about how development works in Firefox.

Success Criteria

• Args are removed, and all call sites adjusted
• After that, the engine compiles, and passes the shell tests (run mach jit-test and mach jstests).

Questions

If you have questions, feel free to visit us on in the SpiderMonkey room on Matrix. If you don't have a Matrix account, you can sign up here, or post questions here.

Tips and Tricks:

• SearchFox indexes the Firefox codebase, and allows you to easily find functions, definitions, and more. It's a powerful tool!
• If you're looking at some code in SpiderMonkey, and are trying to figure out how it gets triggered, one of the easiest ways to do this is to inject a crash by putting MOZ_RELEASE_ASSERT(false); into the code, then running the tests. They will fails when they trigger that line.

Comment 1

[pavelp]

i can handle this.

Comment 2

[pavel]

Attachment: Bug 1710495 - Remove unused args from ReportInNotObjectError r?mgaudet

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/607eec37da62
Remove unused args from ReportInNotObjectError r=mgaudet

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/607eec37da62