1710507 - Native context menu on macOS doesn't support RTL

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Itiel]

Attachment: Context menu displayed as LTR

Comment 1

[Itiel]

Attachment: RTL context menu

Screenshot was taken from VLC context menu, macOS version is 10.15.6.

Comment 2

[Markus Stange [:mstange]]

Thanks for catching this! Fix is straightforward.

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1710507 - Make native menus respect the XUL element's directionality. r=emilio

Comment 4

[Markus Stange [:mstange]]

[Tracking Requested - why for this release]: Regression for RTL users

Comment 5

[Markus Stange [:mstange]]

Does this also affect menubar menus? (Based on the code, it should.) Would menubar menus benefit from supporting RTL, too? Or would it be better to only fix context menus and leave menubar menus untouched?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/694844621f2f
Make native menus respect the XUL element's directionality. r=emilio

Comment 7

[Markus Stange [:mstange]]

I've landed a patch which fixes this both for context menus and for menubar menus.

Comment 8

[Itiel]

Chatting with the original reporter sh.yaron (cc'ed here), it makes sense to RTL the menubar as well.

Comment 9

[Markus Stange [:mstange]]

Thanks!

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/694844621f2f

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Is that needed for 89 or can this ride the 90 train?

Comment 12

[Markus Stange [:mstange]]

This seems like a somewhat serious regression for RTL users, so I think it's worth uplifting to 89.

Comment 13

[Markus Stange [:mstange]]

sh.yaron, the patch is in the latest Nightly. Could you check if things now behave the way you would expect? I'm especially interested in whether the menubar menus now look acceptable or if there is any odd-looking mixing of LTR and RTL directions.

Comment 14

[Yaron Shahrabani]

Attachment: Top bar still aligned to the left

This is the top bar after the fix with latest nightly.

The context menus look great, thank you.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mstange, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Romain Testard [:RT]]

Can we please uplift to Beta 89?

Comment 17

[Markus Stange [:mstange]]

(In reply to Yaron Shahrabani from comment #14)

Created attachment 9221932 [details]
Top bar still aligned to the left

Thanks, I've filed bug 1711618 for that.

Comment 18

[Markus Stange [:mstange]]

Comment on attachment 9221211 [details]
Bug 1710507 - Make native menus respect the XUL element's directionality. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: In RTL locales, context menus will be displayed with left-to-right layout instead of right-to-left. This is a regression compared to non-native context menus.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small fix, only affects RTL locales
• String changes made/needed:

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9221211 [details]
Bug 1710507 - Make native menus respect the XUL element's directionality. r=emilio

This is a major regression for RTL languages, approved for 89 beta 14, thanks.

Comment 20

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/74c1ada52f54

Comment 21

[Bogdan Maris, Desktop QA]

Reproduced using an affected Nightly build from 2021-05-10, verified that the context menu is displayed correctly from right to left on using ar and he build of latest Nightly, also using intl.l10n.pseudo - bidi.

Comment 22

[Bogdan Maris, Desktop QA]

Also verified as fixed using latest Firefox Beta 89.0b14 on macOS 11.3.