Closed Bug 1710524 Opened 5 years ago Closed 5 years ago

Intermittent Assertion failure: isIncrementalGCInProgress(), at z:/task_1620662894/src/js/src/gc/GC.cpp:7794

Categories

(Core :: JavaScript: GC, defect, P5)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- fixed
firefox90 --- wontfix
firefox91 --- wontfix
firefox92 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jonco)

References

Details

(Keywords: assertion, intermittent-failure)

Attachments

(1 external file)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=339294215&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fYuFpzpfQpyJkiERI88QLA/runs/0/artifacts/public/logs/live_backing.log


[task 2021-05-10T19:16:42.365Z] TEST-PASS | testFindSCCsStackLimit | ok
[task 2021-05-10T19:16:47.061Z] teAssertion failure: isIncrementalGCInProgress(), at z:/task_1620662894/src/js/src/gc/GC.cpp:7794
[task 2021-05-10T19:16:47.061Z] #01: js::gc::GCRuntime::finishGC (z:\task_1620662894\src\js\src\gc\GC.cpp:7794)
[task 2021-05-10T19:16:47.062Z] #02: cls_testWeakMap_keyDelegates::run (z:\task_1620662894\src\js\src\jsapi-tests\testWeakMap.cpp:113)
[task 2021-05-10T19:16:47.062Z] #03: main (z:\task_1620662894\src\js\src\jsapi-tests\tests.cpp:167)
[task 2021-05-10T19:16:47.062Z] #04: __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[task 2021-05-10T19:16:47.062Z] #05: BaseThreadInitThunk[C:\Windows\system32\KERNEL32.DLL +0x13d2]
[task 2021-05-10T19:16:47.063Z] #06: RtlUserThreadStart[C:\Windows\SYSTEM32\ntdll.dll +0x154e4]
[task 2021-05-10T19:16:47.080Z] exit status 0 for '(make-nonempty)'
[task 2021-05-10T19:16:47.080Z] exit status 0 for 'make check'
[task 2021-05-10T19:16:47.080Z] exit status 0 for 'make check-jit-test'
[task 2021-05-10T19:16:47.080Z] exit status 2147483651 for 'jsapi-tests'```

Steve, can you take a look at this when you get a change? Looks like an assertion failure in testWeakMap_keyDelegates.

Component: JavaScript Engine → JavaScript: GC
Flags: needinfo?(sphink)
Summary: Intermittent teAssertion failure: isIncrementalGCInProgress(), at z:/task_1620662894/src/js/src/gc/GC.cpp:7794 → Intermittent Assertion failure: isIncrementalGCInProgress(), at z:/task_1620662894/src/js/src/gc/GC.cpp:7794
Assignee: nobody → jcoppeard
Flags: needinfo?(sphink)

The problem is that we are waiting for an incremental GC to get past the
prepare phase, but sometimes it ends up finishing completely, which causes
finishGC() to assert. The fix is to be more careful about checking before
calling that.

Depends on D121392

Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca9b5386b47d Fix intermittent failure in testWeakMap_keyDelegates r=sfink
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

None of the recent failures are actually related to this bug.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: