1710548 - Move the contents of calendar/lightning to appropriate places elsewhere in calendar

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Geoff Lankow (:darktrojan)]

Since we've integrated Lightning, there's no need for a separate directory. In this bug I'm going to put the code from there in more logical places so that it's easier to find.

I'll also remove the chrome://lightning/content/ namespace and put everything in chrome://calendar/content/. I'm undecided about chrome://lightning/locale/, the files will remain in place to avoid upsetting the L10n black magic, but I may move the chrome registrations.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Remove the React calendar item editing code. r?mkmelin

I believe this code was created as part of the 2016 GSoC project, but it was unfinished and hasn't been maintained. There are no plans to use it in future, so it's time for it to go. Sorry Paul.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Move everything out of calendar/lightning. r?mkmelin

This removes the calendar/lightning directory from the source and lightning.jar from the packaging. The chrome://lightning/content namespace also disappears here.

Some of this will move again in a few revisions' time, but it is too time-consuming to backport the second moves.

Depends on D114941

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Move everything out of calendar/resources. r?mkmelin

This moves everything out of calendar/resources and into calendar/base.

Depends on D114942

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Merge the code for calendar properties and calendar creation dialogs. r?mkmelin

These two dialogs relied on layers of monkey-patching to keep the code separate for different configurations. Now that all of the code is always shipped, it's time to simplify this tangled mess.

Depends on D114943

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Move the files for calendar item editing into its own folder. r?mkmelin

Depends on D114944

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Clean up a tangle of linter import comments. r?mkmelin

Depends on D114945

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a96ee55c864a
Remove the React calendar item editing code. r=mkmelin
https://hg.mozilla.org/comm-central/rev/c48bd672faa7
Move everything out of calendar/lightning. r=mkmelin
https://hg.mozilla.org/comm-central/rev/716b6cf06eea
Move everything out of calendar/resources. r=mkmelin
https://hg.mozilla.org/comm-central/rev/11664e1a50ac
Merge the code for calendar properties and calendar creation dialogs. r=mkmelin
https://hg.mozilla.org/comm-central/rev/046905ae9986
Move the files for calendar item editing into its own folder. r=mkmelin
https://hg.mozilla.org/comm-central/rev/363f97476a92
Clean up a tangle of linter import comments. r=mkmelin

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Move invitation utils from ltn. to cal. r=lasana

Comment 11

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Rename Lightning CSS files. r=lasana

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1710548 - Rename Lightning elements and functions. r=mkmelin

This eliminates almost everything remaining named "Lightning" or "ltn" and not involved in L10n or preferences somehow.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84c199a7e837
Move invitation utils from ltn. to cal. r=lasana
https://hg.mozilla.org/comm-central/rev/064732289685
Rename Lightning CSS files. r=lasana
https://hg.mozilla.org/comm-central/rev/cd7fd9f1ef7b
Rename Lightning elements and functions. rs=mkmelin

Comment 14

[Worcester12345]

Still lots of open bugs against "Lightning":

https://bugzilla.mozilla.org/buglist.cgi?product=Calendar&product=MailNews%20Core&product=Thunderbird&query_format=advanced&short_desc=lightning&classification=Client%20Software&classification=Components&resolution=---&short_desc_type=allwordssubstr&order=Importance&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=15758380