Problems in serialization (PASS vs "PASS") causes lots of unnecessary meta data updates for wptsync bot
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox91 fixed)
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: whimboo, Assigned: jgraham)
Details
Attachments
(2 files, 1 obsolete file)
As it can be seen in the history of the following file the meta data for test statuses gets updated back and forth between e.g PASS
and "PASS"
:
This adds a lot of extra commits to these files, which makes it hard to find real changes.
Assignee | ||
Comment 1•3 years ago
|
||
We were previously constructing some expected values as a list of
StringNode objects due to make_value_node incorrectly calling
make_node for list items. This is wrong as StringNode types can only
be on the lhs of an expression (e.g. if os == "linux") but never on
the right hand side (which is always a ValueNode or ListNode with ValueNode
children).
StringNodes are always serialized with quotes and this was causing
values to flip flop between quoted and unquoted forms in some cases.
At the same time we clean up the end of line handling when
serializing, which previously caused us to often end up with an
additional newline at the end of files.
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
I think I figured out where the bug was, but oh my goodness this code has a lot of cases :)
Assignee | ||
Comment 3•3 years ago
|
||
We were previously constructing some expected values as a list of
StringNode objects due to make_value_node incorrectly calling
make_node for list items. This is wrong as StringNode types can only
be on the lhs of an expression (e.g. if os == "linux") but never on
the right hand side (which is always a ValueNode or ListNode with ValueNode
children).
StringNodes are always serialized with quotes and this was causing
values to flip flop between quoted and unquoted forms in some cases.
At the same time we clean up the end of line handling when
serializing, which previously caused us to often end up with an
additional newline at the end of files.
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/c12ba7e19c6f Consistenly serialize list values as unquoted where possible, r=whimboo https://hg.mozilla.org/integration/autoland/rev/4ee05dc03d18 Don't serialize extra whitespace at the end of a meta file, r=whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29441 for changes under testing/web-platform/tests
Updated•3 years ago
|
Comment 7•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c12ba7e19c6f
https://hg.mozilla.org/mozilla-central/rev/4ee05dc03d18
Reporter | ||
Comment 8•3 years ago
|
||
James, the upstream merge didn't happen yet. Could you please have a look? Thanks.
Upstream PR was closed without merging
Upstream PR merged by jgraham
Reporter | ||
Updated•3 years ago
|
Description
•