1710617 - Port bug 1709641: Adjust dark mode modal dialog background

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Richard Marti (:Paenglab)]

We need to follow as we have now subdialogs with two background colours.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1710617-dark-dialog.patch

They use a lighter background for the dialogs that makes the buttons/menulist background not well contrasting to the background. I darkened the button background a bit. What do you think?

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9221325 [details] [diff] [review]
1710617-dark-dialog.patch

Review of attachment 9221325 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for jumping on this so quickly.

Unfortunately this needs a bit more work as the dark theme changes from m-c are breaking a lot of contrast and accessibility in many areas.
I don't really understand how they're picking colors, but anyway, let's deal with this.

We should force our own colors and I think we should stick with the "old" `#2A2A2E` as it's a neutral dark color with AAA readability.

The subdialogs have a strange boxed area with a different color, at least on Linux.
Also the new background from m-c looks horrible when elements light highlighted tabs or text are present. (What's up with this blue on blue on blue tint background trend?

I'll attach a screenshot to show the problems.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Contrast-issues.png

Not sure what's happening but not all subdialogs are styled consistently. Some have dark borders, some have white text on primary buttons, some have black text.
It's a mess.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1710617-dark-dialog.patch

Using now the #2A2A2E background colour. To better fit to different background colours I'm using now the Photon in-content button colours.

The "Edit Card..." dialog issue isn't a problem of this patch. The abNewCardDialog.xhtml dialog is also used as stand alone dialog for the AB. It loads the themeableDialog.css and dialogShadowDom.js which interfere with the in-content styles. This should be done in a separate bug either by not loading this files in in-content (if this is possible) or by splitting this dialog.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9221427 [details] [diff] [review]
1710617-dark-dialog.patch

Review of attachment 9221427 [details] [diff] [review]:
-----------------------------------------------------------------

This is good, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/24e9d29d419f
Port bug 1709641: Adjust dark mode modal dialog background. r=aleca