Closed Bug 1710629 Opened 4 months ago Closed 2 months ago

Bookmarks menu button panel has wrong spacing between icons and title

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect
Points:
2

Tracking

()

VERIFIED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- verified
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- wontfix
firefox92 --- verified

People

(Reporter: mak, Assigned: bigiri)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [proton-door-hangers] [priority:2b])

Attachments

(2 files)

Attached image Screenshot (310).png

After adding the bookmarks menu button to the toolbar, I see wrong spacing between the icon and the button, while the spacing is correct in the Library > Bookmarks view or the toolbar chevron menu.
The icon is just too close to the title.
This is Windows 10.

Priority: -- → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [priority:2b]
Assignee: nobody → bigiri
Status: NEW → ASSIGNED

Modified bookmarks menu button panel padding in Windows to match the appearance of that panel in MacOS.

Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c51eaf636b0
Adjust bookmarks menu button panel padding r=mak
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Please nominate this for ESR91 approval when you get a chance.

Flags: needinfo?(bigiri)
Flags: qe-verify+

Comment on attachment 9230747 [details]
Bug 1710629 - Adjust bookmarks menu button panel padding r=mak

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes poor visual spacing.
  • User impact if declined: Bookmark icons will be too close to the title on Windows.
  • Fix Landed on Version: 92
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS only changes isolated to the bookmarks menu.
  • String or UUID changes made by this patch:
Flags: needinfo?(bigiri)
Attachment #9230747 - Flags: approval-mozilla-esr91?

Comment on attachment 9230747 [details]
Bug 1710629 - Adjust bookmarks menu button panel padding r=mak

Approved for 91.1esr.

Attachment #9230747 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
QA Whiteboard: [qa-triaged]

Reproduced the issue in release 91.0 (build id: 20210804193234) using Windows 10.
Verified - Fixed in latest Nightly 93.0a1 (build id: 20210811213739), Beta 92.0b3 and 91.1.0esr (build id: 20210812202727). The spacing between the icon and the title of the bookmarks is correct in the bookmarks menu button after adding it to the toolbar.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Points: --- → 2
You need to log in before you can comment on or make changes to this bug.