1710629 - Bookmarks menu button panel has wrong spacing between icons and title

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Marco Bonardo [:mak]]

Attachment: Screenshot (310).png

After adding the bookmarks menu button to the toolbar, I see wrong spacing between the icon and the button, while the spacing is correct in the Library > Bookmarks view or the toolbar chevron menu.
The icon is just too close to the title.
This is Windows 10.

Comment 1

[Bernard Igiri]

Attachment: Bug 1710629 - Adjust bookmarks menu button panel padding r=mak

Modified bookmarks menu button panel padding in Windows to match the appearance of that panel in MacOS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c51eaf636b0
Adjust bookmarks menu button panel padding r=mak

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0c51eaf636b0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR91 approval when you get a chance.

Comment 5

[Bernard Igiri]

Comment on attachment 9230747 [details]
Bug 1710629 - Adjust bookmarks menu button panel padding r=mak

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes poor visual spacing.
• User impact if declined: Bookmark icons will be too close to the title on Windows.
• Fix Landed on Version: 92
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS only changes isolated to the bookmarks menu.
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9230747 [details]
Bug 1710629 - Adjust bookmarks menu button panel padding r=mak

Approved for 91.1esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/fd34cd0543a4

Comment 8

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in release 91.0 (build id: 20210804193234) using Windows 10.
Verified - Fixed in latest Nightly 93.0a1 (build id: 20210811213739), Beta 92.0b3 and 91.1.0esr (build id: 20210812202727). The spacing between the icon and the title of the bookmarks is correct in the bookmarks menu button after adding it to the toolbar.