1710651 - Proton: Spacing in One offs area is too big.

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Pablo]

Attachment: emptyspace.jpg

Affected versions
89.0b10 beta
90.0a1 nightly

Affected platforms
Ubuntu 20 64bit , win10 64bit, MacOS 10.14

Preconditions
Proton ON (by default on nightly and beta)

Steps to reproduce
-open new tab
-click on address bar
-ceck one offs area.
-check space between "this time search with" and the google one-off,
-check space between google one-off and the next one-off.

Actual result
There is an empty space between the "this time search with" and the google one off that has a size
and there is a space between each other one-off but that space is not the same as figma design

Expected result
according to figma that space should be smaller. The one after the text and the one between one-offs.

Comment 1

[Pablo]

Hi romain, could you please set a priority for bug?
thanks!

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1710651: Make distance of oneoff buttons narrow.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d15639877f7e
Make distance of oneoff buttons narrow. r=desktop-theme-reviewers,harry

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d15639877f7e

Comment 5

[Mehmet]

Attachment: actual_vs_expected.png

Hello Daisuke, thank you for the adjusting.

The spacing between the text and the first one off icon looks a bit too narrow compared to the other spacings between the one off icons. Any chance to add a few more pixels between the text and the first one off icon to look a bit more balanced?

Many chance for checking :)

Comment 6

[Daisuke Akatsuka (:daisuke)]

Hello Mehmet, thank you for your comment!

What I had fixed in this bug is below.
https://phabricator.services.mozilla.com/D115184#3745623
And, according to our design document, that space is less than the others, it seems an expected result.

But, I want to double-check it with the reviewer of my patch.
Harry, what do you think?

Comment 7

[Harry Twyford]

I spoke to Amy in UX and she agrees we should make the spacing even, like in Mehmet's screenshot above.

Comment 8

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Harry.
I will do that.

Comment 9

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1710651: Make space between header label and icon wider to be same as space between icons.

Comment 10

[Mehmet]

(In reply to Daisuke Akatsuka (:daisuke) from comment #6)

Hello Mehmet, thank you for your comment!

What I had fixed in this bug is below.
https://phabricator.services.mozilla.com/D115184#3745623
And, according to our design document, that space is less than the others, it seems an expected result.

But, I want to double-check it with the reviewer of my patch.
Harry, what do you think?

(In reply to Harry Twyford [:harry] from comment #7)

I spoke to Amy in UX and she agrees we should make the spacing even, like in Mehmet's screenshot above.

Thank you, Daisuke and Harry, for doing the adjustment :)

FYI: I found 2 further polishing issues and reported these in separate bug 1712775.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a59e80e52b60
Make space between header label and icon wider to be same as space between icons. r=desktop-theme-reviewers,harry

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a59e80e52b60

Comment 13

[Pablo]

Attachment: space.jpg

Hi daisuke

i tested this on windows10, Mac 10.15 and Ubuntu 20, using latest nightly 91.0a1 and beta 90.0b1
but the space is still too big, (not like the screenshot posted on comment#5 )

for example in that screenshot, the empty space is almost like 1 google icon.

but when i check on nightly, the empty space is like 2 google icons

should spaces be shorter?

Comment 14

[Harry Twyford]

Attachment: Screen Shot 2021-06-02 at 4.39.00 PM.png

Pablo, the spaces are consistent in your screenshot. The label and the Google icon are the same distance apart as the Google icon and the Amazon icon. Here's a screenshot with some guide lines. The two sets are the same distance apart.

Comment 15

[Harry Twyford]

Ah, I'm wrong here. Sorry Pablo. In the screenshot in comment 5, there is less space between the label and the Google icon than there is between the Google icon and the Amazon icon. Mehmet, was there a reason for that? The implementation of this bug puts equal space between all elements, as illustrated in comment 14.

Comment 16

[Mehmet]

(In reply to Harry Twyford [:harry] from comment #15)

Ah, I'm wrong here. Sorry Pablo. In the screenshot in comment 5, there is less space between the label and the Google icon than there is between the Google icon and the Amazon icon. Mehmet, was there a reason for that? The implementation of this bug puts equal space between all elements, as illustrated in comment 14.

Hi Harry, the current implementation with the equal space between all elements is absolutely fine and it reflects the intention with my screenshot in comment 5. Sorry for the bad spacing in the screenshot. I hadn't worked with a ruler - it was only eye-measured :(

Comment 17

[Harry Twyford]

Great! Pablo, let's consider this bug complete.

Comment 18

[Pablo]

verified fix on WIndows10, ubuntu 20 and Mac 10.15
with beta 90.0b1 and Nightly 91.0a1