Closed
Bug 1710667
Opened 3 years ago
Closed 3 years ago
Clean up Letter- and Word-spacing helpers in nsTextFrame
Categories
(Core :: Layout: Text and Fonts, defect, P5)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
90 Branch
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
The static helper functions LetterSpacing()
and WordSpacing()
in nsTextFrame.cpp each take an optional nsStyleText
param, and look it up themselves if not provided. We can clean this up a bit, because all callers actually have the nsStyleText
on hand already and can simply pass it by const-reference; no need for it to be optional.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94b1ec106df5 LetterSpacing and WordSpacing helpers don't need their nsStyleText param to be optional. r=emilio
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•