Closed Bug 1710713 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28962 - [Resource Timing] Align transferSize to spec

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28962 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28962
Details from upstream follow.

b'Yoav Weiss <yoavweiss@chromium.org>' wrote:

[Resource Timing] Align transferSize to spec

Aligning transferSize to the spec means that response header sizes will
no longer be directly exposed, even for same origin resources or
resources with Timing-Allow-Origin headers.
This is because it seems unsafe[1] to expose header sizes directly.

It also means that redirect chains won't count towards the size exposed
in transferSize. While we could specify and accumulate redirect body
sizes, it seems like we'd be better off reporting redirects directly[2]
in the future, in case it becomes a priority.

PSA: https://groups.google.com/a/chromium.org/g/blink-dev/c/Sny4FO5_y5E

[1] https://github.com/w3c/resource-timing/issues/238
[2] https://w3c.github.io/web-performance/meetings/2021/2021-03-18/index.html

Bug: 1185801
Change-Id: Iba071c6bb74c5522e3f1ed2586f082f11a7a68a0
Reviewed-on: https://chromium-review.googlesource.com/2878693
WPT-Export-Revision: 1c24b7a04ce61a8397d96b6f2ef62cee0f15d094

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests and 1 subtests

Status Summary

Firefox

OK : 22
PASS : 19
FAIL : 19

Chrome

OK : 22
PASS : 23
FAIL : 15

Safari

OK : 19
PASS : 12
FAIL : 21
TIMEOUT: 2
ERROR : 2
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/resource-timing/SO-XO-SO-redirect-chain-tao.https.html
Verify that cross origin resources' timings are not exposed when same-origin=>cross-origin=>same-origin redirects have no Timing-Allow-Origin: headers.: FAIL (Chrome: PASS, Safari: FAIL)
Verify that cross origin resources' timings are not exposed when same-origin=>cross-origin=>same-origin redirects have Timing-Allow-Origin: headers only on some of the responses.: FAIL (Chrome: PASS, Safari: FAIL)
Verify that cross origin resources' timings are not exposed when same-origin=>cross-origin=>same-origin redirects have Timing-Allow-Origin: headers with a specific origin.: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/cross-origin-start-end-time-with-redirects.html
Verify that cross-origin resources don't implicitly expose their redirect timings: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/nextHopProtocol-is-tao-protected.https.html
Add TAO-less iframe from remote origin. Make sure nextHopProtocol is the empty string: FAIL (Chrome: PASS, Safari: FAIL)
/resource-timing/same-origin-from-cross-origin-redirect.html
Verify that cross origin resources' timings are exposed when the final resource at the end of an HTTP redirect chain is same-origin.: FAIL (Chrome: PASS, Safari: FAIL)
/resource-timing/sizes-cache.any.worker.html
PerformanceResourceTiming sizes caching test: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/sizes-cache.any.html
PerformanceResourceTiming sizes caching test: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/sizes-cache.any.sharedworker.html
PerformanceResourceTiming sizes caching test: FAIL (Chrome: FAIL)
/resource-timing/sizes-cache.any.serviceworker.html
PerformanceResourceTiming sizes caching test: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/sizes-redirect-img.html
PerformanceResourceTiming sizes redirect image - direct URL: FAIL (Chrome: FAIL, Safari: FAIL)
PerformanceResourceTiming sizes redirect image - same origin redirect: FAIL (Chrome: FAIL, Safari: FAIL)
PerformanceResourceTiming sizes redirect image - cross origin redirect: FAIL (Chrome: FAIL, Safari: FAIL)
PerformanceResourceTiming sizes redirect image - cross origin to same origin redirect: FAIL (Chrome: FAIL, Safari: FAIL)
PerformanceResourceTiming sizes redirect image - same origin to remote origin to same origin redirect: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/sizes-redirect.any.sharedworker.html
PerformanceResourceTiming sizes Fetch with redirect test: FAIL (Chrome: FAIL)
/resource-timing/sizes-redirect.any.serviceworker.html
PerformanceResourceTiming sizes Fetch with redirect test: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/sizes-redirect.any.html
PerformanceResourceTiming sizes Fetch with redirect test: FAIL (Chrome: FAIL, Safari: FAIL)
/resource-timing/sizes-redirect.any.worker.html
PerformanceResourceTiming sizes Fetch with redirect test: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/832d544f7fd2
[wpt PR 28962] - [Resource Timing] Align transferSize to spec, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b45cb8eb989b
[wpt PR 28962] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/832d544f7fd2
https://hg.mozilla.org/mozilla-central/rev/b45cb8eb989b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.