1710756 - Expose preventFocusRing to error pages.

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1710756 - Expose FocusOptions.preventsFocusRing to error pages. r=edgar,smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f66ab2d9d10
Expose FocusOptions.preventsFocusRing to error pages. r=edgar

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2f66ab2d9d10

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey emilio, I'm not having much luck getting this to work on server-not-found about:neterror pages. It looks like when browsing to a non-existent domain, we return false for IsCallerChromeOrErrorPage right here: https://hg.mozilla.org/integration/autoland/file/eb2e067f5266428059803f6d8ba7239ff66275ce/dom/base/nsContentUtils.cpp#l2138. Any idea why?

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Silly mistake.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1710756 - Use WindowGlobalOrNull rather than WindowOrNull in IsCallerChromeOrErrorPage. r=nika,smaug

WindowOrNull only works if the object is a window (or document,
apparently), but won't work more generally. Use the global of the
object instead so that it works for properties exposed on Element.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc1458da3e8f
Use WindowGlobalOrNull rather than WindowOrNull in IsCallerChromeOrErrorPage. r=mccr8

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cc1458da3e8f