1710830 - Perma [Tier2] tests/jit-test/jit-test/tests/environments/bug1710089.js | [CodeCoverage] Setting handlers for process <random>. (code 3, args "") [0.2 s]

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=339484594&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/U5-0ApO9TgSPROzL-CA_mA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-05-12T10:59:18.843Z] 10:59:18     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/environments/bug1671762.js | Success (code 0, args "--blinterp-eager") [0.2 s]
[task 2021-05-12T10:59:19.005Z] 10:59:19     INFO -  [CodeCoverage] Setting handlers for process 8833.
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  /builds/worker/workspace/build/tests/jit-test/jit-test/tests/environments/bug1710089.js:3:4421 InternalError: function nested too deeply
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  Stack:
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -    @/builds/worker/workspace/build/tests/jit-test/jit-test/tests/environments/bug1710089.js:31:21
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  Exit code: 3
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  FAIL - environments/bug1710089.js
[task 2021-05-12T10:59:19.006Z] 10:59:19  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/environments/bug1710089.js | [CodeCoverage] Setting handlers for process 8833. (code 3, args "") [0.2 s]
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  INFO exit-status     : 3
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  INFO timed-out       : False
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  INFO stderr         2> [CodeCoverage] Setting handlers for process 8833.
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  INFO stderr         2> /builds/worker/workspace/build/tests/jit-test/jit-test/tests/environments/bug1710089.js:3:4421 InternalError: function nested too deeply
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  INFO stderr         2> Stack:
[task 2021-05-12T10:59:19.006Z] 10:59:19     INFO -  INFO stderr         2> @/builds/worker/workspace/build/tests/jit-test/jit-test/tests/environments/bug1710089.js:31:21
[task 2021-05-12T10:59:19.068Z] 10:59:19     INFO -  [CodeCoverage] Setting handlers for process 8840.
[task 2021-05-12T10:59:19.068Z] 10:59:19     INFO -  /builds/worker/workspace/build/tests/jit-test/jit-test/tests/environments/bug1710089.js:3:4421 InternalError: function nested too deeply
[task 2021-05-12T10:59:19.068Z] 10:59:19     INFO -  Stack:
[task 2021-05-12T10:59:19.068Z] 10:59:19     INFO -    @/builds/worker/workspace/build/tests/jit-test/jit-test/tests/environments/bug1710089.js:31:21
[task 2021-05-12T10:59:19.068Z] 10:59:19     INFO -  Exit code: 3
[task 2021-05-12T10:59:19.068Z] 10:59:19     INFO -  FAIL - environments/bug1710089.js```

Comment 1

[Nicolas B. Pierron [:nbp]]

Matthew, sounds like code coverage builds might hit a different error than the OOM from Bug 1710089.
I guess you can either disable this test case for code coverage runs, or fix it.

Also, today I learnt that we have an InternalError: function nested too deeply error …

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Sorry, I am actually going to redirect back to Iain. I meant to get to this earlier today, but am at EOD, so there's a better chance Iain will get a fix prepped before me.

(Iain: Sorry!)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1710089

Comment 4

[Iain Ireland [:iain]]

Attachment: Bug 1710830: Make testcase work with full parsing r=mgaudet!

Each let apparently creates a new hop in the emitter that isn't reflected in the number of hops seen by WarpBuilder. The problem only shows up when full parsing. The simplest fix is to convert let to var; the resulting testcase still triggers the original bug in WarpBuilder, but doesn't break code coverage builds.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2333c162dd5f
Make testcase work with full parsing r=mgaudet

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2333c162dd5f