1710836 - [Proton] The "Bookmark Toolbar" field is not correctly displayed in Library

Status: NEW

(Firefox :: Theme, defect, P2)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: Screenshot from 2021-05-12 11-06-47.png

Affected versions

• latest Beta 89.0b11
• Nightly 90.0a1

Affected platforms

• Win 10 x64
• Win 8.1 x64
• Ubuntu 16.04 x86

Steps to reproduce

1. Launch Firefox.
2. Go to Library (CTRL/CMD + Shift + O).
3. Click on a website from the History section, then select "Bookmark Page" option via context menu.

Expected result

• The field is correctly displayed for The "Bookmark Toolbar" section.

Actual result

• The field is not correctly displayed for The "Bookmark Toolbar" section. It seems that the field is displayed with a light gray if the option is hovered.

Suggested Severity

• S2, since this is a user facing issue on Library.

Regression range

• This seems to be introduced with the proton changes. I cannot reproduce the problem with proton disabled. I will check for a regression range asap.

Additional notes

• please see the attached screenhsot.
• on Win and MacOS, I have also encountered the issues mentioned in bug 1710322.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=df4b939f11b763f9ab3d0a834fb921b5a5ed253f&tochange=42f6412b7bc1c6ccafe07c33e0027c6c065c3acd

Comment 2

[Alice0775 White]

Bug 1702293 did not fix this issue.

Comment 3

[Harry Twyford]

I can only reproduce this in Light mode. I'm downgrading this to an S3 since this menu is very obscure and the presence of text and a dropdown arrow indicates the element is interactive, even if the background has no contrast.