Closed Bug 1710839 Opened 4 years ago Closed 3 years ago

Remove the "remote.enabled" preference

Categories

(Remote Protocol :: Agent, task, P2)

task
Points:
2

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [bidi-m1-mvp])

Attachments

(1 file)

Currently the availability of the Remote Agent is being controlled via the remote.enabled preference. And only with this preference set to true the command line argument --remote-debugging-port will be available, which initializes the Remote Agent and makes it available within Gecko.

Given that we are basically out of the experimental phase for CDP and no longer restrict the Remote Agent to Firefox Nightly only, there seems to be no reason to actually keep this preference around.

Seeing the pref gone will also help me with combining the build flags for Marionette and Remote Agent over on bug 1695031. Then both Marionette and Remote Agent will show the same behavior and can be started via the command line arguments.

Instances of this preference can be found here:
https://searchfox.org/mozilla-central/search?q=remote.enabled&path

Freddy, mind having a look at comment 0? Do you see any kind of security implication when we are going to remove the preference and make the Remote Agent always available via the command line argument. This would be inline with Marionette, and we soon will require it for the WebDriver BiDi implementation. Thanks.

Flags: needinfo?(fbraun)

Given that you already (and will continue to) require a command line parameter to be present for it to be enabled, I don't see any obvious risks.

Flags: needinfo?(fbraun)
Points: --- → 2
Priority: -- → P2
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9999df73037 [remote] Remove remote.enabled preference. r=remote-protocol-reviewers,Gijs,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: