Closed Bug 1710847 Opened 3 years ago Closed 3 years ago

Dark mode modals are unreadable if the OS is using high contrast mode

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Platform:
Desktop
All
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox88 unaffected, firefox89+ verified, firefox90 verified)

Status:
VERIFIED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 + verified
firefox90 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-modals] [priority:2a] [proton-uplift])

Attachments

(1 file)

Bug 1710847 - fix high contrast mode interaction with dark mode dialogs, r?mstriemer
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

I broke this in bug 1709641.

[Tracking Requested - why for this release]:

FWIW because this broke with bug 1709641 which got uplifted and because it impacts readability exactly for people (on all OSes) who need more contrast, so I think this should be P1 or P2a, and we should get the CSS-only change uplifted to 89.

Severity: -- → S2
status-firefox88: --- → unaffected
status-firefox89: --- → affected
tracking-firefox89: --- → ?
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/646c72ffc272
fix high contrast mode interaction with dark mode dialogs, r=mstriemer,preferences-reviewers

https://hg.mozilla.org/mozilla-central/rev/646c72ffc272

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Priority: -- → P2
Whiteboard: [proton-modals] → [proton-modals] [priority:2a]

This issue is Verified as fixed in our latest Nightly build 90.0a1 (2021-05-13), Only the Bug 1709396 and Bug 1709508 remain.

status-firefox90: fixed → verified

Shilpa, can I request uplift here?

Flags: needinfo?(smohanty)

Yes, Gijs. Let's proceed ahead with the Uplift.

Flags: needinfo?(smohanty) → needinfo?(gijskruitbosch+bugs)

Comment on attachment 9221600 [details]
Bug 1710847 - fix high contrast mode interaction with dark mode dialogs, r?mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: Unreadable text when using high contrast mode and Firefox's dark theme
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See earlier comments
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): 2 CSS changes to put the offending background colour change in a media query that only applies outside of high contrast mode. This won't affect any other UI parts and we can't really make this particular part worse...
  • String changes made/needed: Nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9221600 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9221600 [details]
Bug 1710847 - fix high contrast mode interaction with dark mode dialogs, r?mstriemer

Approved for 89.0b12.

Attachment #9221600 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

This issue is Verified as fixed in our latest beta 89.0b12 on Mac, Windows and Ubuntu.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox89: fixed → verified
Flags: qe-verify+
Whiteboard: [proton-modals] [priority:2a] → [proton-modals] [priority:2a] [proton-uplift]
Has Regression Range: --- → yes
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: