Closed Bug 1710853 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26069 - [weakref] ...may call window.onerror.

Categories

(Core :: JavaScript Engine, task, P4)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26069 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26069
Details from upstream follow.

b'Rick Waldron <waldron.rick@gmail.com>' wrote:

[weakref] ...may call window.onerror.

When called from HostCleanupFinalizationRegistry, if calling the callback throws an error, this will be caught within the RunJobs algorithm and reported to the host. HTML does not apply the RunJobs algorithm, but will also report the error, which may call window.onerror.

Component: web-platform-tests → JavaScript Engine
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 20 tests and 1 subtests

Status Summary

Firefox

OK : 20
PASS: 1[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, GitHub] 2[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug]
FAIL: 34[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug] 35[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, GitHub]

Chrome

OK : 20
PASS: 1
FAIL: 35

Safari

OK : 20
PASS: 2
FAIL: 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/js/builtins/weakrefs/cleanup-prevented-with-reference.optional.any.worker.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/cleanup-prevented-with-reference.optional.any.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/cleanup-prevented-with-unregister.optional.any.html
Cleanup might be prevented with an unregister usage: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/cleanup-prevented-with-unregister.optional.any.worker.html
Cleanup might be prevented with an unregister usage: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/finalizationregistry-cleanupCallback-gets-a-microtask.optional.any.html
HostCleanupFinalizationRegistry is an implementation-defined abstract operation that is expected to call CleanupFinalizationRegistry(finalizationRegistry) at some point in the future, if possible.: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug] (Chrome: FAIL, Safari: PASS)
/js/builtins/weakrefs/finalizationregistry-cleanupCallback-gets-a-microtask.optional.any.worker.html
HostCleanupFinalizationRegistry is an implementation-defined abstract operation that is expected to call CleanupFinalizationRegistry(finalizationRegistry) at some point in the future, if possible.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotask.optional.any.worker.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotask.optional.any.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotaskMutationObserver.optional.window.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback.optional.any.worker.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback.optional.any.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/holdings-multiple-values.optional.any.html
Requires FinalizationRegistry.prototype.cleanupSome: FAIL (Chrome: FAIL, Safari: FAIL)
undefined as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
null as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
"" as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
{} as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
42 as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
true as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
false as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
Symbol(1) as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/holdings-multiple-values.optional.any.worker.html
Requires FinalizationRegistry.prototype.cleanupSome: FAIL (Chrome: FAIL, Safari: FAIL)
undefined as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
null as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
"" as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
{} as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
42 as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
true as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
false as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
Symbol(1) as registered holding value: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/reentrancy.optional.any.worker.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/reentrancy.optional.any.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/return-undefined-with-gc.optional.any.html
Return undefined regardless the result of CleanupFinalizationRegistry: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/return-undefined-with-gc.optional.any.worker.html
Return undefined regardless the result of CleanupFinalizationRegistry: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/unregister-cleaned-up-cell.optional.any.html
Cannot unregister a cell that has been cleaned up: FAIL (Chrome: FAIL, Safari: FAIL)
/js/builtins/weakrefs/unregister-cleaned-up-cell.optional.any.worker.html
Cannot unregister a cell that has been cleaned up: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/639fd567423a
[wpt PR 26069] - [weakref] ...may call window.onerror., a=testonly

https://hg.mozilla.org/mozilla-central/rev/639fd567423a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.