Closed Bug 1710896 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28976 - [GridNG] Baseline second pass

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28976 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28976
Details from upstream follow.

b'Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com>' wrote:

[GridNG] Baseline second pass

This change updates the GridNG alignment logic to allow for baseline
eligibility to change depending on the phase of grid layout algorithm.

This is accomplished with an optional fallback baseline on GridItemData,
along with some logic to handle baselines being indefinite, depending on
where the algorithm is.

There is a bit of a circular dependency with synthesized baselines - we
cannot determine whether baselines are synthesized without laying out the
item. So this change also separates the concept of baseline eligibility
and the ability to synthesize baselines via the 'CanLayoutGridItem'
helper.

Bug: 1045599
Change-Id: Ifd5f47599cf494faadb330705a638df8c012c95b
Reviewed-on: https://chromium-review.googlesource.com/2873217
WPT-Export-Revision: fe24ba1f52e9fdd16ef84890ca6bad2c8f9e35b5

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 6 subtests

Status Summary

Firefox

OK : 3
PASS: 4
FAIL: 38

Chrome

OK : 3
PASS: 42

Safari

OK : 3
PASS: 36
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html
.inline-grid 2: FAIL
.inline-grid 3: FAIL
.inline-grid 4: FAIL
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html
.inline-grid 1: FAIL
.inline-grid 2: FAIL
.inline-grid 3: FAIL
.inline-grid 4: FAIL
.inline-grid 5: FAIL
.inline-grid 6: FAIL
.inline-grid 7: FAIL
.inline-grid 8: FAIL
.inline-grid 9: FAIL
.inline-grid 10: FAIL
.inline-grid 11: FAIL
.inline-grid 12: FAIL
.inline-grid 13: FAIL
.inline-grid 14: FAIL
.inline-grid 15: FAIL
.inline-grid 16: FAIL
.inline-grid 17: FAIL
.inline-grid 18: FAIL
.inline-grid 19: FAIL
.inline-grid 20: FAIL
.inline-grid 21: FAIL
.inline-grid 22: FAIL
.inline-grid 23: FAIL
.inline-grid 24: FAIL
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html
.grid 1: FAIL
.grid 2: FAIL
.grid 3: FAIL
.grid 4: FAIL
.grid 5: FAIL
.grid 6: FAIL

New Tests That Don't Pass

/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html
.inline-grid 2: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 3: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 4: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 7: FAIL (Chrome: PASS, Safari: FAIL)
.inline-grid 8: FAIL (Chrome: PASS, Safari: FAIL)
.inline-grid 9: FAIL (Chrome: PASS, Safari: FAIL)
.inline-grid 10: FAIL (Chrome: PASS, Safari: FAIL)
.inline-grid 11: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html
.inline-grid 1: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 2: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 3: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 4: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 5: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 6: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 7: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 8: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 9: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 10: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 11: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 12: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 13: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 14: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 15: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 16: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 17: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 18: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 19: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 20: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 21: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 22: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 23: FAIL (Chrome: PASS, Safari: PASS)
.inline-grid 24: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html
.grid 1: FAIL (Chrome: PASS, Safari: PASS)
.grid 2: FAIL (Chrome: PASS, Safari: PASS)
.grid 3: FAIL (Chrome: PASS, Safari: PASS)
.grid 4: FAIL (Chrome: PASS, Safari: PASS)
.grid 5: FAIL (Chrome: PASS, Safari: PASS)
.grid 6: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfc030af3775 [wpt PR 28976] - [GridNG] Baseline second pass, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f91983b1c88 [wpt PR 28976] - [GridNG] Baseline second pass, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ced2ec8c1cad [wpt PR 28976] - [GridNG] Baseline second pass, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ced2ec8c1cad

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.