Closed Bug 1710915 Opened 3 years ago Closed 2 years ago

Change classic form icon in SeaMonkey composer

Categories

(SeaMonkey :: Composer, enhancement)

Product:
SeaMonkey
Component:
Composer
Type:
enhancement

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.93
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.10.1)

Attachments

(1 file, 3 obsolete files)

1710915-formicon-v1_1-25311.patch
294.21 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-release+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

The new form icon looks out of place and ugly.

Flags: needinfo?(frgrahl)
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Flags: needinfo?(frgrahl)
status-seamonkey2.57esr: affected → ---
tracking-seamonkey2.57esr: ? → ---
Whiteboard: SM2.53.11
Attached patch 1710915-wip-formicon-25311.patch (obsolete) — — Splinter Review

macOS needs to be added so still wip. Broken since Bug 1684611 and no one noticed :(

Attached patch WIP-1710915-formicon-25311.patch (obsolete) — — Splinter Review

One mac icon done

Attachment #9251261 - Attachment is obsolete: true
Attached patch 1710915-formicon-25311.patch (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): bug 1684611
User impact if declined: no macOS form icon and shoddy classic one.
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Attachment #9251273 - Attachment is obsolete: true
Attachment #9251413 - Flags: review?(iannbugzilla)
Attachment #9251413 - Flags: approval-comm-release?
Attachment #9251413 - Flags: approval-comm-esr60?

Minor misalignment corrected.

[Approval Request Comment]
Regression caused by (bug #): bug 1684611
User impact if declined: no macOS form icon and shoddy classic one.
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Attachment #9251413 - Attachment is obsolete: true
Attachment #9251413 - Flags: review?(iannbugzilla)
Attachment #9251413 - Flags: approval-comm-release?
Attachment #9251413 - Flags: approval-comm-esr60?
Attachment #9252401 - Flags: review?(iannbugzilla)
Attachment #9252401 - Flags: approval-comm-release?
Attachment #9252401 - Flags: approval-comm-esr60?

Comment on attachment 9252401 [details] [diff] [review]
1710915-formicon-v1_1-25311.patch

[Triage Comment]
r/a=me

Attachment #9252401 - Flags: review?(iannbugzilla)
Attachment #9252401 - Flags: review+
Attachment #9252401 - Flags: approval-comm-release?
Attachment #9252401 - Flags: approval-comm-release+
Attachment #9252401 - Flags: approval-comm-esr60?
Attachment #9252401 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/4c328d629bff
Replace placeholder form icon in SeaMonkey composer. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.93

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d457fb88549046a0e7e11f347811b7f15dede57c
Replace placeholder form icon in SeaMonkey composer. r=IanN a=IanN

status-seamonkey2.53: affected → fixed
tracking-seamonkey2.53: ? → +
Whiteboard: SM2.53.11 → SM2.53.10.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: