1710942 - Pocket articles - update focus state styles

Status: RESOLVED INVALID

(Firefox :: New Tab Page, enhancement, P2)

Description

[Amy Churchwell [:amy]]

For both dark and light themes on newtab the Pocket article cards need updated focus styles.

Article headers and borders (2px solid) need to be these colors during focus:

Light theme: #0060DF
Dark theme: #00DDFF

(Please use ::focus-visible if possible, so the focus ring only shows when navigating with keyboard.)

Comment 1

[Amy Churchwell [:amy]]

Check browser.newtabpage.activity-stream.discoverystream.compactLayout.enabled to see if this has been fixed.

Comment 2

[Saman]

Hi, I am an outreachy intern and I want to contribute to this kindly assign it to me Thank you.

Comment 3

[Amy Churchwell [:amy]]

(In reply to Saman from comment #2)

Hi, I am an outreachy intern and I want to contribute to this kindly assign it to me Thank you.

Hi there! Unfortunately, the Pocket team is conducting an A/B test to update the card designs on the new tab page so let me double-check this is still required.

Hey Scott — do we still want this change, or is it blocked by the card design test?

Comment 4

[Scott [:thecount] Downe]

From what I can tell the Pocket cards focus style for both border and headers is var(--newtab-primary-action-background); which is what topsites is. I think that's probably what we want, no?

I think there was someone doing theme work on newtab not long ago, and they probably aligned this then, is my guess.

Either way, this is probably no longer a bug someone should be working on. Can probably just resolve this one imo.