Closed
Bug 1710984
Opened 3 years ago
Closed 3 years ago
Validate ImmutableScriptData also on non-debug build and use soft-failure
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
Bug 1710984 - Part 1: Validate the size of ImmutableScriptData also on non-debug build. r?tcampbell!
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
bug 930307 suggests that the ImmutableScriptData instance decoded in XDRImmutableScriptData can contain broken data.
Adding mode validation can prevent crash
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D115047
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/704565ea5bc9 Part 1: Validate the size of ImmutableScriptData also on non-debug build. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/a6de6f3f36b5 Part 2: Add marker at the end of Stencil XDR. r=tcampbell
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/704565ea5bc9
https://hg.mozilla.org/mozilla-central/rev/a6de6f3f36b5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•