1710994 - [macOS] button hover highlight disappears when right clicking a button

Status: NEW

(Core :: Widget: Cocoa, defect, P2)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: macOS_focus.mov

Affected versions

• 90.0a1 (20210512174859)
• 89.0b11 (20210511190154)

Affected platforms

• macOS 11.3.1 ARM and Intel

Steps to reproduce

1. Open Firefox and right-click a random button from the toolbar or tabs bar.

Expected result

• The focus is kept on the right-clicked button.

Actual result

• No focus can be seen on the right-clicked button.

Regression range

• This is not a regression because this was reproducible when native context menus were enabled by default in Nightly (bug 1700679)

Notes

• Attached a screen recording.
• On Firefox 88.0.1 the focus is kept on the right-clicked button until the mouse is moved but while the context menu is opened the other buttons can be focused.

Comment 1

[Mehmet]

Same on the Bookmarks Bar, e.g. right-click on a Bookmark button -> The Context Menu appears, but the Bookmark button does not keep hover focus.

Comment 2

[Romain Testard [:RT]]

On Windows the on hover focus is not retained if you move you cursor off of the element although it remains if your cursor remains on the element post right click.
It seems there are 3 variations of what can happen:
1 On hover focus enabled with context menu until the context menu disappears (previous mac behavior?) - i.e if the context menu is activated somewhere, on hover focus remains on the specific element that have the context menu activated
2 On hover focus is independent from the context menu selection (pre and post MR1 behavior on Windows) - i.e if the context menu is activated somewhere, on hover focus follows the mouse hover regardless
3 On hover focus disabled if context menu is activated (current mac behavior)

Katie, do you have a strong opinion regarding how this specific on hover scenario should be handled on macOS?

Comment 3

[Markus Stange [:mstange]]

(In reply to Romain Testard [:RT] from comment #2)

1 On hover focus enabled with context menu until the context menu disappears (previous mac behavior?) - i.e if the context menu is activated somewhere, on hover focus remains on the specific element that have the context menu activated
2 On hover focus is independent from the context menu selection (pre and post MR1 behavior on Windows) - i.e if the context menu is activated somewhere, on hover focus follows the mouse hover regardless
3 On hover focus disabled if context menu is activated (current mac behavior)

1 never happened in Firefox, I think. The previous Mac behavior was 2, like on Windows.
However, 1 is what happens in Safari, and I think it's desirable.

One thing we could do here is to set an attribute like ismenutriggernode="true" on the toolbarbutton while a context menu is open on it, and then style elements with that attribute the same as hovered elements.

Comment 4

[katieC]

Option 1 seems the most logical - if a context menu is specific to an icon (and cursor location / tab order focus ) - display the icon with its background hover state to help visually connect the content to the trigger.