171106 - [cust] more toolbar customization ideas

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Joe Hewitt (gone)]

Some more things I want to do to toolbar customization:

1. add spacers, which consume 20px or so, as opposed to just springs

2. organize the palette by category, which will help if start getting a ton of
buttons thrown in there

3. Place a label underneath spacer, spring, separator, and all toolbaritems. 
toolbaritem should support a "title" attribute for this use.

4. Toolbar add-ons will want to add their own toolbars, in addition to putting
their buttons in the palette so they can be moved around.  The problem here is
that when these toolbars are empty, they stick around forever, so need a way for
toolbarset to support toolbars that can be overlayed but never created if they
are empty.

5. Per-toolbar mode and icon size

Comment 1

[Joe Hewitt (gone)]

1. and 3. are fixed.

Comment 2

[Tobias Tinkerman]

*** Bug 171728 has been marked as a duplicate of this bug. ***

Comment 3

[Richard Klein]

Right clicking in a toolbar area should give the toolbar menu as a popup instead
of just having customize.  This would add greatly to the convenience. 

Comment 4

[Jesse Ruderman]

6. It's hard to tell what you're dragging.  To make this easier, the item could
become attached to mouse cursor as you drag it (like on Max OS X?).

7. If the rightmost item on the main toolbar is a separator, it's impossible to
drag the throbber to the right of the separator.

8. The grey box for a space makes it hard to see what the toolbar looks like
with the space.  What if the grey box only appeared when you hover over a space?

9. It's hard to drag spaces and separators.  Having grey boxes on hover (like in
8) would make this easier.

10. In toolbar customization mode, I can't right-click an extra toolbar to
destroy it (cf bug 172141, can't right-click an extra toolbar to hide it).

11. The button "Restore Default Set" is next to "Add New Toolbar", so I thought
it removed the empty, extra toolbar I had created.  Instead, it reset all of my
customizations and gave me no way to undo.

Comment 5

[Darren Salt]

wrt 7, it *is* possible; you just have to accurately position the pointer.

12. Hide/show toolbars should be available in customisation mode. (Menu click
over customisation window? 'Hide this toolbar' in the toolbar menu?)

Comment 6

[alanjstr]

Copy / Cut / Paste / Fullscreen Toggle buttons
http://www.mozillazine.org/forums/viewtopic.php?t=3200

I think these would assist in an IE transition.

Comment 7

[Chu Alan "sprite"]

Attachment: customize dialog patch, part 3 of 3 [v1]

there are three patches concerning customize dialog in total.
(bug 178078, bug 171454, bug 171106)

this patch contains: 
1. category list of icons (using <expander/> defined in pref window)
2. code clean up (mostly about palette item add/remove)
3. fixes a warning about aItem.disabled

Comment 8

[Chu Alan "sprite"]

Comment on attachment 118199 [details] [diff] [review]
customize dialog patch, part 3 of 3 [v1]

P.S. i have removed the spacer stuff in the last hbox, should i add it back?

Comment 9

[Chu Alan "sprite"]

Hewitt: in fact i plan to read the expander id+label from an attribute of the
toolbar button and generate expander on the fly, but i do not know how to put
those attribute in place. (cause i think reading expander id+label from the
toolbar button will facilitate third-party toolbar buttons (i.e. they can add
new category without modifying those files)

Comment 10

[Chu Alan "sprite"]

Attachment: addresses some drag-and-drop usability issues

1. fixes bug on DND feedback not appearing on the right end of the toolbar.
2. make hovered control contains a border
3. makes the DND feedback on the left and right more visible (added
padding-left and padding-right to toolbar)

Comment 11

[Chu Alan "sprite"]

Comment on attachment 119453 [details] [diff] [review]
addresses some drag-and-drop usability issues

P.S. please beware that patches may conflict when applying... sigh

Comment 12

[Chu Alan "sprite"]

Attachment: same patch, with update to make drop marker visible before window-controls.

patch against CVS, may conflict with previous patches.

Futhermore, user should not be able to drop objects after window-controls in
full screen mode, may be we should add some more attributes. (However, that
requires more works...)

Comment 13

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 14

[Dan]

I have a couple more suggestions for Firefox toolbars. This looks like the right
place, if not I'll re-sumbit them in a new bug.

First, if you rest the mouse over the items in the customisation panel then you
should get the same tooltips as you do over the items the browser toolbars (e.g.
'Reload' item gives 'Reload current page'). Spacer items need special tooltips
with a brief description (e.g. 'Flexible Space' item gives something like 'This
spacer expands to fill the available space in the toolbar, pushing the items
either side of it along the toolbar').

Second, the text 'drag an item onto the toolbars to add it' could be modified to
something like 'rest the mouse pointer over an item in this panel for a
description, drag items to and from the toolbars above to customise them'.

This was after reading the Mozillazine thread at
http://www.mozillazine.org/talkback.html?article=4554#3 .

Comment 15

[Jon Henry]

Chu, if you still need to get this patch reviewed (I realize it's a year
later...) you should try Mike Connor or Ben, Hewitt is no longer active.

Comment 16

[Oomingmak]

13. Add CANCEL button to the customize toolbar dialog. 

At the moment, if you try a new layout and mess things up, all you can do is
accept the changes with 'DONE' (and ruin your layout) or loose your previous
layout by being forced to Restore the Default set.

I thought it was standard to be able to cancel your way out of any dialog if you
change your mind.

Comment 17

[Ria Klaassen (not reading all bugmail)]

*** Bug 319933 has been marked as a duplicate of this bug. ***

Comment 18

[Jonathan Nieder]

Is there a reason this is one bug?

Comment 19

[pile0nades]

12. The Customize Toolbar window should not be limited to four columns of buttons, because if you resize the window, you see a lot of wasted space. I have a hacky css fix for this at http://userstyles.org/style/show/547 .

Comment 20

[Phil Ringnalda (:philor)]

(In reply to comment #18)
> Is there a reason this is one bug?

No. There's absolutely no reason to have a "what I was working on four years ago" bug turn into a bug and enhancement pile-on. If anyone has a still-valid bug or enhancement they think should be made to customization, they should file it in Toolkit: Toolbars and Toolbar Customization (after making sure it's not a duplicate).