1711154 - gather telemetry on how long it takes to scan for client certificates

Status: RESOLVED FIXED

(Core :: Security: PSM, task)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

We can't directly measure how long it takes osclientcerts to find certificates, but we can measure how long it takes Firefox to scan all modules for client certificates, which will have to do.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1711154 - collect telemetry on how long it takes to look for client auth certificates r?bbeurdouche data-review?chutten

Enabling osclientcerts by default may have an impact on how long it takes to
scan for client authentication certificates. This patch adds telemetry to
measure this.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: telemetry data review

Comment 3

[Chris H-C :chutten]

Comment on attachment 9222238 [details]
telemetry data review

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 96.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b4d4f52df08
collect telemetry on how long it takes to look for client auth certificates r=bbeurdouche data-review?chutten

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4b4d4f52df08

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 9222234 [details]
Bug 1711154 - collect telemetry on how long it takes to look for client auth certificates r?bbeurdouche data-review?chutten

Beta/Release Uplift Approval Request

• User impact if declined: No telemetry before we enable osclientcerts by default.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1712064
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small, straightforward patch that gathers one telemetry measurement.
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9222234 [details]
Bug 1711154 - collect telemetry on how long it takes to look for client auth certificates r?bbeurdouche data-review?chutten

Approved for the beta branch before 89 RC, thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f31e9d367527