1711219 - Poor contrast on compose window with Linux dark theme and Thunderbrid default theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot

Comment 1

[Richard Marti (:Paenglab)]

This line slipped in. You can see this that it isn't nicely formatted (no space after comma).

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1711219-menu-menulist-colors.patch

Fixed the issue Emilio reported.

I also fixed the menubar colours when a theme is used (dark system theme and light TB theme and vice versa).

For more tests I installed Breeze and found that it changes the titlebar colour between active and inactive. The calendar buttons on the tab bar didn't change their colour accordingly. Fixed this too.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9221999 [details] [diff] [review]
1711219-menu-menulist-colors.patch

Review of attachment 9221999 [details] [diff] [review]:
-----------------------------------------------------------------

This is good as it fixes the issue reported.
Could we use the occasion to quickly fix the background color of focused elements?
In this situation (OS dark theme + TB default theme) the focused background color of the field is identical to the header area bg, and there's no visual separation other than the focus ring.
It looks kind of a mistake. We should maintain the same darker color of the field when focused.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1711219-menu-menulist-colors.patch

The [brighttext] applied to dark Linux theme too but then the variable wasn't set. Changed to :root[lwt-tree-brighttext] to apply only with themes that set the variables.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9222006 [details] [diff] [review]
1711219-menu-menulist-colors.patch

Review of attachment 9222006 [details] [diff] [review]:
-----------------------------------------------------------------

One little thing is missing.
When the msgIdentity menulist is focused and hovered, the background color changes to the light grey, but it shouldn't. (Screen recording coming)

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: menulist-active-hover.gif

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1711219-menu-menulist-colors.patch

This should fix the msgIdentity focus hover.

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9222012 [details] [diff] [review]
1711219-menu-menulist-colors.patch

Review of attachment 9222012 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks.
Let's update the commit message to better report the changes.
Something like: "Fix menulist and menu colors for dark variation".

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1711219-menu-menulist-colors.patch

Updated the commit message.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c14c70a4a91
Fix menulist and menu colors for dark variation. r=aleca