1711229 - [Proton] The new added login is no longer focused with proton enabled

Status: RESOLVED WONTFIX

(Firefox :: about:logins, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: Screenshot_1.png

Affected versions

• Firefox 90.0a1 (20210514094222)
• Firefox 89.0b12 (20210513185752)

Affected platforms

• Windows 10x64
• Windows 7x64
• macOS 10.15
• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox.
2. Open about:logins.
3. Click on the "Create New Login" button from the bottom part of the Login list.
4. Observe the new added login.

Expected result

• The new added login is focused and has a gray background.

Actual result

• The new added login is not focused and the background is white.

Suggested Severity

• S4 since is only an UI issue

Regression range

• • This seems to be introduced with proton changes, I will investigate more in order to find a regression range.

Additional notes

• Please observe the attached screenshot.
• This only occurs with Proton enabled (browser.proton.enabled=true).
• The new added login in correctly focused on a dark theme.

Comment 1

[:Gijs (he/him)]

Can you provide a comparison screenshot? Also, are there steps missing in comment 0? You're clicking "Add new login" - but the screenshot shows an existing login.

Comment 2

[Giorgia Nichita, Release Desktop QA]

Attachment: protondisabled.png

Here is the attachment with proton disabled (browser.proton.enabled=false). You can easily observe the gray background and the focused new login section.
It doesn't matter if a login is already created or you just click "Add new login", with proton enabled the section is not focused and the gray background is not present.

Comment 3

[Giorgia Nichita, Release Desktop QA]

Hello! I have searched for a regression range and I found this:

Regression range

• First bad: 2021-05-18
• Last good: 2021-03-01
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8aa1b80a8c6b66cccc2e37080fbf6197eee8d801&tochange=1716229005d8b97f305bd663b8bc8d3fec4a4f3a
• Potential regressor: Bug 1700109

Hope this helps! Please let me know if you need more information. Thanks

Comment 4

[:Gijs (he/him)]

Attachment: Screenshot with proton

I'm sorry, I really don't understand what you think the bug is here.

This is what things look like for me immediately after clicking "create new login". Note the thick vertical blue bar that indicates selection in the list on the left, and the blue focus outline for the text field in the focused field of the "new login" form. Typing puts text into this focused text field, so it is definitely focused. Can you elaborate on what you mean in comment 0 by "is not focused" ? Do you see something else? Am I missing part of the steps?

Comment 5

[Giorgia Nichita, Release Desktop QA]

Hi! Sorry if this was confusing. The bug I'm referring is related to the background color. With proton enabled I am still expecting the background to be gray.

Comment 6

[Giorgia Nichita, Release Desktop QA]

Attachment: screenshot.png

Hi Gijs! Just to elaborate on my previous comment:

With proton disabled, the focused login has a gray background. Now, with proton enabled, the gray background no longer exists, only the blue line from the left part of the login remains. The issue is visible when creating a new login or when focusing an existing one.
Also, the background of the page where the login details are displayed (in the right) is gray with proton disabled.

Comment 7

[:Gijs (he/him)]

I think that the change in background colour for the main login area is intentional - both before and after it was using the default in-content background colour. The default background colour changed. I don't think the big area on the right appearing grey was intentional as an indication of focus or selection.

For the selected item in the list on the left, bug 1698421 changed this explicitly to use the default background colour. I don't know why -- comment 0 in that bug does not really explain. It's possible that this now being identical to the background colour was not foreseen in bug 1698421 - though that too is a bit odd because the change in bug 1693276 predates that one (though proton was not enabled by default at the time). :ntim or Jared, do you know what the idea was there, and if we still want a distinct background colour for the selected item in the about:logins list?

Comment 8

[Sam Foster [:sfoster] (he/him)]

I think I saw some discussion of this #fx-desktop-dev:mozilla.org, but I couldn't tell if this is an actual bug we need to keep on file. As far as I can tell, there is no usability regression here and subjectively it looks fine to me. I'm inclined to wontfix this unless there's something I'm missing.

Comment 9

[:Gijs (he/him)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #8)

I think I saw some discussion of this #fx-desktop-dev:mozilla.org, but I couldn't tell if this is an actual bug we need to keep on file. As far as I can tell, there is no usability regression here and subjectively it looks fine to me. I'm inclined to wontfix this unless there's something I'm missing.

wfm!