Closed Bug 1711257 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29000 - List item supports block fragmentation

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29000 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29000
Details from upstream follow.

b'Koji Ishii <kojii@chromium.org>' wrote:

List item supports block fragmentation

The list marker should be aligned to the first line box of the
contents. This patch supports when a list item is block-
fragmented, and the first line box is pushed to the non-first
fragment.

Following changes are in this patch:

  1. Adds a flag |HasUnpositionedListMarker| to
    |NGBlockBreakToken|. This indicates that the first fragment
    did not have line boxes, and therefore following fragments
    of the list item should place the list marker.
  2. Removes |NGLayoutResult::UnpositionedListMarker|. This was
    used to propagate list markers from inline fragments to the
    containing list item.
    To support the block fragmentation without increasing the
    complexity, |NGBlockLayoutAlgorithm| for the list item
    retrieves the list marker, keep it in |container_builder_|,
    and place it when it finds the first line box in the
    descendant boxes.
  3. |NGColumnLayoutAlgorithm| needs similar code to support
    when a list item has multi-columns.

Bug: 1206409
Change-Id: I2c89104c93b85f7604a8596dfc44d12725a44958
Reviewed-on: https://chromium-review.googlesource.com/2885398
WPT-Export-Revision: 63158803550b4f44fdf9bb8f3ab88ea55bdb56e3

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-multicol/multicol-list-item-008.html: FAIL

New Tests That Don't Pass

/css/css-multicol/multicol-list-item-008.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31c2f486e7a4
[wpt PR 29000] - List item supports block fragmentation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ef496e3135f5
[wpt PR 29000] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/31c2f486e7a4
https://hg.mozilla.org/mozilla-central/rev/ef496e3135f5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.