Closed
Bug 1711260
Opened 3 years ago
Closed 3 years ago
Use the (prefers-contrast) media query for the themeable dialogs
Categories
(Thunderbird :: Theme, task)
Thunderbird
Theme
Tracking
(thunderbird_esr78 unaffected)
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
|
15.56 KB,
image/png
|
Details | |
|
4.40 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
Screenshot from 2021-05-14 11-56-09.png
Actually the themeable dialogs don't work well with the HighContrastInverse on Linux as they are only defined for Windows HC.
|
Assignee | |
Comment 1•3 years ago
|
||
Move the HC defines to shared and use the prefers-contrast media query.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9221991 -
Flags: review?(alessandro)
|
||
Comment 2•3 years ago
|
||
We have some poor contrast for the radio buttons in the theamable dialog with HighContrastInverse OS theme.
|
|
||
Updated•3 years ago
|
Attachment #9221991 -
Flags: review?(alessandro)
|
|
Assignee | |
Comment 3•3 years ago
|
||
This radio buttons should be better.
Attachment #9221991 -
Attachment is obsolete: true
Attachment #9222008 -
Flags: review?(alessandro)
|
|
||
Comment 4•3 years ago
|
||
Comment on attachment 9222008 [details] [diff] [review] 1711260-prefers-contrast-themeable-dialog.patch Review of attachment 9222008 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #9222008 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Updated•3 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → 90 Branch
|
||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/247efe7b3635
Use the (prefers-contrast) media query for the themeable dialogs. r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•