1711261 - Address bar and Search bar lack contrast in OSX High Contrast mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Note
This issue doens't reproduce when "Display contrast" is set to Normal (default)

Affected versions

• Firefox 89 beta 12
• latest Nightly 90.0a1 2021-05-14

Affected platforms

• macOSX 10.15, macOSX 11.4 beta

Prerequisites

• Set system theme to Light
• Go to System Preferences - Accessibility and select "Increase contrast" option, then move the cursor one level to the right for "Display contrast" item
• Enable Search Bar

Steps to reproduce

1. Open Firefox and set the theme to Default or Light
2. Check address bar and search bar in close and open state

Expected result

• Address bar and search bar can be easily differentiated from the toolbar. Address bar results pane has a shadow.

Actual result

• Address bar and search bar have the exact same color as toolbar
• Address bar dropdown results pane has no shadow on a retina display

Regression range

• Not a regression, introduced with Proton

Additional notes

• Also reproducible when system theme is Dark and Firefox is set to Light theme

Comment 1

[Harry Twyford]

Attachment: Bug 1711261 - Increase toolbar contrast in Mac HCM. r?#desktop-theme-reviewers!,mstange

This patch draws a 1px black line around the Urlbar in macOS HCM, which resembles other high contrast macOS apps. This patch only support Light HCM mode. Since we apply the Firefox Dark lwttheme when in Dark mode, and we do not support lightweight themes in high contrast mode, significantly more work is required to implement basic support for dark HCM on Mac.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a565118c581
Increase toolbar contrast in Mac HCM. r=mstange,desktop-theme-reviewers,dao

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0a565118c581

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Harry Twyford]

Comment on attachment 9224341 [details]
Bug 1711261 - Increase toolbar contrast in Mac HCM. r?#desktop-theme-reviewers!,mstange

Beta/Release Uplift Approval Request

• User impact if declined: Low contrast in main UI on macOS when "Increase contrast" is toggled in System Preferences.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only, verified in Nightly.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9224341 [details]
Bug 1711261 - Increase toolbar contrast in Mac HCM. r?#desktop-theme-reviewers!,mstange

Approved for 91 beta 9, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1ed51c1fc80

Comment 9

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified fixed on OSX 10.14, Light HCM & Firefox system theme using Firefox 91 beta 9 and Nightly 92.0a1.