Closed Bug 171127 Opened 22 years ago Closed 21 years ago

bug_email.pl is broken

Categories

(Bugzilla :: Bugzilla-General, defect)

2.17
x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: jussi, Assigned: alex)

References

Details

(Keywords: helpwanted, regression)

Attachments

(1 file)

The schema change from the new groups system broke bug_email.pl. The relevant part from the script output is: select bit from groups where name='ReadInternal': Unknown column 'bit' in 'field list' at globals.pl line 246. There is propably more references to the old groups table.
Can we consider this a feature? Please? :)
Target Milestone: --- → Bugzilla 2.18
Same problem here. Any news on this bug?
ccing the people that have been working with the new groups schema...
CCing Dan Berlin, who from stuff I've seen around, I know is actually using the bug_email stuff. I'd appreciate any input or fixes you'd be willing to provide on these bugs :-)
I've found that if I change all occurances of "bit" to "id" in each of the SQL statements in bug_email.pl, it will work. Well, I didn't test it very well, but at least it accepts my emails and puts them in the database.
T.R. Fullhart had a partial fix which I have now completed. His work-around simply allowed the bug to be entered into the database but would not handle any groupset nor fix the processmail issue. My proposed patch fixes both. Only one caveat, and that is the bug may be entered into a group which the user has no access rights to. I did not bother adding this check since this interface is via email and email is dead easy to fake up. If the user does enter an incorrect group, then the groups they are listed in will be given, so if anyone needs this additional check, it should be easy enough to add.
Attachment #129362 - Flags: review?
Comment on attachment 129362 [details] [diff] [review] Fixes group and mail problem patch applies and it compiles. Generally looks good, but haven't tested, but this is only contrib anyway. :)
Attachment #129362 - Flags: review? → review+
Blocks: 192512
Checking in contrib/bug_email.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v <-- bug_email.pl new revision: 1.16; previous revision: 1.15 done
Status: NEW → RESOLVED
Closed: 21 years ago
Flags: approval+
Resolution: --- → FIXED
Assignee: justdave → alex
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: