171127 - bug_email.pl is broken

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Jussi Sirpoma]

The schema change from the new groups system broke bug_email.pl. The relevant
part from the script output is:

select bit from groups where name='ReadInternal': Unknown column 'bit' in 'field
list' at globals.pl line 246.

There is propably more references to the old groups table.

Comment 1

[Bradley Baetz (:bbaetz)]

Can we consider this a feature? Please? :)

Comment 2

[Jan-Peter Koopmann]

Same problem here. Any news on this bug?

Comment 3

[Dave Miller [:justdave]]

ccing the people that have been working with the new groups schema...

Comment 4

[Dave Miller [:justdave]]

CCing Dan Berlin, who from stuff I've seen around, I know is actually using the
bug_email stuff.  I'd appreciate any input or fixes you'd be willing to provide
on these bugs :-)

Comment 5

[T.R. Fullhart]

I've found that if I change all occurances of "bit" to "id" in each of the SQL
statements in bug_email.pl, it will work. Well, I didn't test it very well, but
at least it accepts my emails and puts them in the database.

Comment 6

[Alex Schuilenburg]

Attachment: Fixes group and mail problem

T.R. Fullhart had a partial fix which I have now completed.  His work-around
simply allowed the bug to be entered into the database but would not handle any
groupset nor fix the processmail issue.  My proposed patch fixes both.

Only one caveat, and that is the bug may be entered into a group which the user
has no access rights to.  I did not bother adding this check since this
interface is via email and email is dead easy to fake up.  If the user does
enter an incorrect group, then the groups they are listed in will be given, so
if anyone needs this additional check, it should be easy enough to add.

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 129362 [details] [diff] [review]
Fixes group and mail problem

patch applies and it compiles.	Generally looks good, but haven't tested, but
this is only contrib anyway. :)

Comment 8

[Dave Miller [:justdave]]

Checking in contrib/bug_email.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v  <--  bug_email.pl
new revision: 1.16; previous revision: 1.15
done