Closed Bug 1711328 Opened 3 years ago Closed 3 years ago

Dark theme back / forward / reload icons become/remain invisible on the main toolbar / navbar

Categories

(Core :: Graphics: WebRender, defect, P2)

Firefox 90
Desktop
Windows
defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 + fixed

People

(Reporter: aja, Assigned: aosmond)

References

(Regression)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

open context menu, use reload/back/forward there.

Actual results:

normal state reload button icon on main toolbar goes/stays invisible. (transient X and reload animation are still visible when appropriate)

Expected results:

reload/back/forward should stay visible

Buttons' icons are functional, have hover state backgrounds, just that icons go invisible somehow.
Looks as if context fill/stroke somehow gets lost?

Restarting FF gets reload/back/forward icon visibility back to normal again.

Unable to reproduce with light themes.

Disabling extensions and resetting toolbar customization to default don't help.

Unfortunately, haven't been able to determine regressing change using mozregression, but am confident it's been within past few days.
So, perhaps it works fine with new profiles.

Filing this bug nonetheless, as I've seen a few references to others hitting this issue:
http://forums.mozillazine.org/viewtopic.php?p=14893086#p14893086
https://www.reddit.com/r/firefox/comments/ncmfb9/weekly_discussion_for_nightly_builds_for_20210515/gy6cwbd/?utm_source=reddit&utm_medium=web2x&context=3

I reproduced this too today (90.0a1 (2021-05-14) (64-bit)), however after closing and restarting nightly the buttons showed up and didn't disappear again.

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Address Bar

I'm hitting this as well, and found a reliable way to reproduce it so I could run mozregression.

2021-05-16T10:50:12.809000: DEBUG : Found commit message:
Bug 1704792 - Part 7. Integrate use of ImageIntRegion with WebRender display lists. r=jrmuizel

This patch hooks up the ImageIntRegion to the blob recording and makes
any necessary adjusts to the display list creation to take advantage of
it.

Differential Revision: https://phabricator.services.mozilla.com/D114986

Steps taken during mozregression runs, using blank as profile so its a new profile:

  • Let the browser window open to newtab page
  • Click "wikipedia" top site item to navigate to wikipedia
  • right click the content to open context menu
  • Click the reload button inside context menu

Actual results:
Reload-icon disappears after the page has loaded. Stop icon+animation works fine though.

My OS is using dark mode, so by default that profile used dark version of the theme. I ran mozregression again but this time set ui.systemUsesDarkTheme to 0 so the build used light version of the theme. Interestingly the issue does not happen in light mode at all.

For good measure I ran mozregression the third time, without that pref and the results are exactly the same as with the first run. It really does seem to only happen using dark theme.

To add to the previous comment: this method only resulted in reload-button icon being lost. I have not found a reliable way to reproduce other navigation buttons to get lost. But I imagine they suffer from essentially the same root cause.

Thank you for the steps to reproduce.

Flags: needinfo?(aosmond)
Regressed by: 1704792
Has Regression Range: --- → yes

Other steps to reproduce:

  1. Sign into a Firefox Account.
  2. Customize the toolbar.
  3. Drag the Firefox Account button to the list of unused toolbar elements.
    The icon disappears often at this step.
  4. Customize the toolbar again.
  5. Drag the Firefox Account icon to the toolbar.
    The icon can also disappear at this step.

[Tracking Requested - why for this release]:
Regression in 90, and icons disappearing (apparently) randomly isn't something we should ship to users.

Component: Address Bar → Graphics: WebRender
Keywords: regression
OS: Unspecified → Windows
Product: Firefox → Core
Hardware: Unspecified → Desktop
Summary: proton dark theme url bar left, right, reload icons become/remain invisible → Dark theme back / forward / reload icons become/remain invisible on the main toolbar / navbar

It appears toggling the pref image.svg.blob-image has a similar effect, but now all the icons disappear.

Assignee: nobody → aosmond
Severity: -- → S3
Priority: -- → P2

I think bug 1711164 will fix this issue.

Flags: needinfo?(aosmond)
Depends on: 1711164

In initial testing of latest autolanded bug 1711164 patch https://hg.mozilla.org/integration/autoland/rev/66200d07c1d1
seems to resolve this issue...at least the easily-reproduced disappearing reload icon.

(In reply to Bill Goldstein [:aja] (UTC-6) from comment #11)

In initial testing of latest autolanded bug 1711164 patch https://hg.mozilla.org/integration/autoland/rev/66200d07c1d1
seems to resolve this issue...at least the easily-reproduced disappearing reload icon.
Above backed out for minor test issue. Followup patch https://hg.mozilla.org/integration/autoland/rev/7811b10f32a1 WFM, too.

Marking as fixed per comment 12.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.