1711377 - Bookmarks get duplicated when dragging from unsorted bookmarks ("Other bookmarks") in library

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Twisted_Code]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

clicked on history button on toolbar
clicked manage history
(possibly skipable)did some stuff with my history
Started using the library view to manage bookmarks
clicked "other bookmarks" folder
searched folder for "Java" so I could move all Java related bookmarks to their own folder
selected all results except one
Dragged results to the Java folder

Actual results:

the bookmarks were duplicated
the duplicates showed up in my results for "other bookmarks" as well as showing up in the destination folder

Expected results:

the bookmarks should not be duplicated
bookmarks in a folder besides "other bookmarks" should not be included when searching "other bookmarks"
PS: I had an issue similar to this in the past when trying to cut & paste bookmarks (that were tagged and I was viewing the tag folder that lists bookmarks with that tag), which also resulted in duplication. It might be related, though unfortunately I never reported it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Twisted_Code]

sounds good bug-bot. I don't know anything about reporting and tagging stuff; I just report what I see.

Comment 3

[Rares Doghi, Desktop QA]

Hi Twisted_Code I tried to reproduce this issue but without success and I think I might be missing something, do you mind getting a screen recording of the issue ?
When I reach the Bookmarks Library and search for the java Bookmarks I have in a specific folder and then I drag them into a different folder, they all show like nothing moved, they dont disappear from the current folder until you click the other folders and they refresh, after clicking a different folder and going back to the folder with all the java bookmarks I noticed that only one remains there and the others are moved without issues into the new folder.

Can you please try this issue with a fresh profile ? creating some new Bookmarks and trying to Move them between folders like before ? and see if the issue still occurs with a fresh profile as well ?

You can find the steps here on how to create a fresh profile: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

You can also try downloading our latest Nightly build and recheck the issue there ? maybe its been fixed already and it didnt reach Release yet.
You can find the build here: https://nightly.mozilla.org/

Comment 4

[Twisted_Code]

I'll give it a try with a fresh profile, since if it has to do with my profile or add-ons, it's probably not a Firefox thing. if it does work though, I'll record it... at least if I can find a good screen recorder for the job.
it'll have to wait until I finish my college assignment for this week, though.

Comment 5

[Mark Banner (:standard8)]

Hi, Firefox doesn't have a way to search specific folders. When you select "Other Bookmarks" and search, then you are still searching all the bookmarks.

Firefox defaults to moving bookmarks when you move them out of a search.

If you manually look for the bookmarks you moved you should see they no longer exist in the Other Bookmarks folder.

We that think with this clarification, you'll see that Firefox is working as expected. We do already have bug 1449361 on file for enabling search within specific folders - I will mark it as a duplicate of that one.

Comment 6

[Twisted_Code]

The issue I'm describing seems to have stopped happening. However!

@MarkBanner even though the issue is apparently resolved, you should unmark this as a duplicate. What I meant by "results" in my description of "actual results" was that when I look at each folder (not use the search field), the duplicated bookmarks show up as a RESULT of selecting that folder (not searching it). Poor choice of words on my part. is there a way to edit my initial message? I'm pretty new to this tracker...

anyway, unless I start having issues again, that's all I have to say about this issue. in fact, can we mark this as resolved instead of a duplicate? Assuming it can be reopened at a later date should it recur, I don't see a reason not to.