1711381 - A page spamming `prompt()` can trigger window prompts when the containing browser window goes away

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P3)

Description

[Lyubomir [:mystiquewolf]]

Attachment: index.html

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

1. Open the file with a single tab in Firefox 89 Beta
2. A prompt appears when the page loads. Do not confirm or close the prompt.
3. Close the single tab while the prompt is open.

Actual results:

The browser closes. The prompt appears on its own window after the browser is closed.

Expected results:

The prompt should not appear at all after closing the browser.

Comment 1

[Lyubomir [:mystiquewolf]]

Attachment: Screenshot_20210516_202553.png

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=803c26c0927131a6e1fffc5ebdebb55e95161ce6&tochange=89c0c4d8d57ce6370cdd095ae1fbaa88031afb96

Regressed by Bug 1680066

Setting prompts.contentPromptSubDialog to false fixes the problem.
Bug 1702495 enabled the preference since firefox89.

Comment 3

[:Gijs (he/him)]

This page infinite-loops if the prompt() doesn't return a name, so it's not the same prompt that's reshowing, it's the page showing a second (or third, or fourth, ...) identical prompt. You can also see this (but as "normal" prompts, not separate windowed ones) if you just cancel out of the prompt instead of closing the browser window.

Still looking at why the windowed prompt happens - it's kind of weird because the problem goes away when I attach a JS debugger...

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1711381 - correctly handle the browser no longer being present for content and tabmodal prompts, r?pbz

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39c32384d7a9
correctly handle the browser no longer being present for content and tabmodal prompts, r=pbz

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on tabPrompts

• backout: https://hg.mozilla.org/integration/autoland/rev/e7499e0e51345ec72dc38cfccc8875c7f1b45b81

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=39c32384d7a9e49a240f53762e44d03d7872637a&selectedTaskRun=esOE6yxXQhyQXJ_gipFOuA.0

• failure logs:

  1. TEST-UNEXPECTED-FAIL | browser/base/content/test/tabPrompts/browser_switchTabPermissionPrompt.js | Test timed out -
  2. TEST-UNEXPECTED-FAIL | browser/base/content/test/tabPrompts/browser_prompt_closed_window.js | Test timed out -

Comment 7

[:Gijs (he/him)]

With many thanks to Mike for helping me debug the strange test issues I was seeing (some of which got filed as 1711740). Try now appears happy: https://treeherder.mozilla.org/jobs?repo=try&revision=c543ecaef781c088bb0e2e9f2b882b0502f2ade1 so I'm relanding.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d8229a81e8d
correctly handle the browser no longer being present for content and tabmodal prompts, r=pbz

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4d8229a81e8d

Comment 10

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 90.0a1 (2021-05-21) on Windows, Mac and Ubuntu.