1711437 - Don't EnsureUniqueInner from cssRules getter.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=jfkthame

Instead, fix up the various content data structures when the stylesheet
is mutated. This makes reading a stylesheet not disable style sharing.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=4897521af98025b99e65f1f463ffd3d1ef051163

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c95330ad7c7
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 2c95330ad7c7 (bug 1711437) for Devtools failures in devtools/client/inspector/markup/test/browser_markup_shadowdom.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=340644513&repo=autoland&lineNumber=17060

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=2c95330ad7c743340b38707b1171363789b9ede3

Backout:
https://hg.mozilla.org/integration/autoland/rev/9635f4a632cbb3bf5655c91682afb6859a50924d

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Not super-sure it was my patch given this: https://treeherder.mozilla.org/jobs?repo=try&revision=ab5588abe14785a5da6d3e465d279781c8607c78

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7944c3f9e5b
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame

Comment 7

[Atila Butkovits]

Backed out for causing mochitest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/88b8bf1539797d53093a721597cede3cf739a014

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-devtools-chrome-e10s%2Cdt7&revision=0570f92e9ffe7db06cd3243034b85023b12d5293&selectedTaskRun=LBj25pH0Rb-unRKfU9iuFw.0

Failure log:
1 - https://treeherder.mozilla.org/logviewer?job_id=340742970&repo=autoland&lineNumber=11037
2 - https://treeherder.mozilla.org/logviewer?job_id=340745565&repo=autoland&lineNumber=14300
3 - https://treeherder.mozilla.org/logviewer?job_id=340747028&repo=autoland&lineNumber=17414

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/998af7ced46f
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/998af7ced46f

Comment 10

[Alexandru Michis [:malexandru]]

Backed out changeset 998af7ced46f (Bug 1711437) for causing Bug 1719963. a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/7b8721ff033aa37d5036caa4d2bfa5127356dd62

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Per discussion with Aryx, and assuming that the crash volume of bug 1719963 isn't very big which it shouldn't, I'll reland this with the hopes of finding a repro for bug 1719963 soonish (the urls in the crash reports didn't repro the issue for me nor Aryx).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e17878eeb86
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0e17878eeb86

Comment 14

[Dorel Luca [:dluca]]

Backed out changeset 0e17878eeb86 (bug 1711437) for causing Bug 1719963. a=backout DONTBUILD

Backout:
https://hg.mozilla.org/mozilla-central/rev/5f0cbbacab6da731998b6367bbf5047934275a83

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee5f3abebb85
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ee5f3abebb85

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta for 92.0b2 due to bug 1719963.
https://hg.mozilla.org/releases/mozilla-beta/rev/0b48d14c2361