Closed Bug 1711437 Opened 4 months ago Closed 2 months ago

Don't EnsureUniqueInner from cssRules getter.

Categories

(Core :: DOM: CSS Object Model, task)

task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox92 --- wontfix
firefox93 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.
No longer blocks: 1707310

Instead, fix up the various content data structures when the stylesheet
is mutated. This makes reading a stylesheet not disable style sharing.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c95330ad7c7
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7944c3f9e5b
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame
Attachment #9222150 - Attachment description: Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=#style,#layout-reviewers → WIP: Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=#style,#layout-reviewers
Attachment #9222150 - Attachment description: WIP: Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=#style,#layout-reviewers → Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=#style,#layout-reviewers
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/998af7ced46f
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Backed out changeset 998af7ced46f (Bug 1711437) for causing Bug 1719963. a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/7b8721ff033aa37d5036caa4d2bfa5127356dd62

Status: RESOLVED → REOPENED
Flags: needinfo?(emilio)
Resolution: FIXED → ---
Target Milestone: 91 Branch → ---
Regressions: 1719963

Per discussion with Aryx, and assuming that the crash volume of bug 1719963 isn't very big which it shouldn't, I'll reland this with the hopes of finding a repro for bug 1719963 soonish (the urls in the crash reports didn't repro the issue for me nor Aryx).

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e17878eeb86
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame
Status: REOPENED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Backed out changeset 0e17878eeb86 (bug 1711437) for causing Bug 1719963. a=backout DONTBUILD

Backout:
https://hg.mozilla.org/mozilla-central/rev/5f0cbbacab6da731998b6367bbf5047934275a83

Status: RESOLVED → REOPENED
Flags: needinfo?(emilio)
Resolution: FIXED → ---
Target Milestone: 92 Branch → ---
Attachment #9222150 - Attachment description: Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=#style,#layout-reviewers → Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=jfkthame
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee5f3abebb85
Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame
Status: REOPENED → RESOLVED
Closed: 3 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Target Milestone: 92 Branch → 93 Branch
See Also: → 1730853
You need to log in before you can comment on or make changes to this bug.