1711449 - [Phase 2 & Phase 3] The click and impressions telemetry are not registered if the "show search suggestions ahead of history" option is unchecked

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Click and Impressions telemetry are not registered.gif

[Notes]:

• Also the following error is displayed in browser console after clicking a QuickSuggest result: Last result is not a quick suggest. Not sure if this error is related or we should log a separate bug for it.
• The issue is not reproducible if the "Show search suggestions ahead of browsing history in address bar results" option is checked.

[Affected versions]:

• Firefox Beta 89.0b13;
• Nightly 90.0a1

[Affected Platforms]:

• Windows 10 x64;
• macOS 10.15.7;
• Linux Mint 20 x64;

[Prerequisites]:

• Have the latest Firefox Nightly installed.
• Have the browser console opened.
• Have the following prefs set:
• browser.urlbar.quicksuggest.enabled to true.
• browser.urlbar.experimental.firefoxSuggestLabels.enabled to true.
• browser.urlbar.quicksuggest.showedOnboardingDialog to true.
• browser.startup.upgradeDialog.version to 89.
• browser.ping-centre.log to true.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "about:preferences#search" page.
3. Uncheck the "Show search suggestions ahead of browsing history in address bar results" option.
4. Type "nike" in the Awesomebar.
5. Click the Nike - Sponsored result.
6. Navigate to "about:telemetry#keyed-scalars-tab" page and search for "contextual.services.quicksuggest" keyed scalars.
7. Observe telemetry registered in the browser console.

[Expected result]:
Step 6: The "contextual.services.quicksuggest.impressions" and "contextual.services.quicksuggest.click" telemetry are correctly registered after following the Step 5.
Step 7: The (contextual-services) telemetry are correctly registered for the impressions and click after following the step 5.

[Actual result]:
Step 6: The "contextual.services.quicksuggest.impressions" and "contextual.services.quicksuggest.click" telemetry are NOT registered.
Step 7: The (contextual-services) telemetry are NOT registered for the impressions and click.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Nan Jiang [:nanj]]

I can reproduce this in the latest Nightly build. Seeing this error logged in the browser console:

Last result is not a quick suggest UrlbarProviderQuickSuggest.jsm:197
    onEngagement resource:///modules/UrlbarProviderQuickSuggest.jsm:197
    tryMethod resource:///modules/UrlbarUtils.jsm:1626
    notifyEngagementChange resource:///modules/UrlbarProvidersManager.jsm:303
    _internalRecord resource:///modules/UrlbarController.jsm:870
    record resource:///modules/UrlbarController.jsm:779
    pickResult resource:///modules/UrlbarInput.jsm:982
    pickElement resource:///modules/UrlbarInput.jsm:681
    handleNavigation resource:///modules/UrlbarInput.jsm:514
    handleCommand resource:///modules/UrlbarInput.jsm:468
    handleKeyNavigation resource:///modules/UrlbarController.jsm:316
    _on_keydown resource:///modules/UrlbarInput.jsm:3199
    maybeDeferEvent resource:///modules/UrlbarEventBufferer.jsm:154
    _on_keydown resource:///modules/UrlbarInput.jsm:3198
    handleEvent resource:///modules/UrlbarInput.jsm:432

Looks like this issue was caused by a program error.

Comment 2

[Drew Willcoxon :adw]

Thanks Cosmin. This was broken by bug 1709992. The quick suggest result isn't always last anymore, like this logic assumes. I should have updated it but I didn't.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1711449 - Don't assume the quick suggest result is last when recording telemetry.

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87c6b1431079bb649294bf8148603acfe88a0cd7

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d3faa51e16dbb2608567e0f3709bc0ee53f4ba0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54d43c856c5b
Don't assume the quick suggest result is last when recording telemetry. r=daleharvey

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/54d43c856c5b

Comment 8

[Nan Jiang [:nanj]]

:adw - Thanks for fixing this up!

I've confirmed with Natalie that we're not going to roll out phase 3 in Fx 89. Also, we would only enroll users who are using the default pref in phase 2, so we don't need to uplift this in 89 beta.

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 90.0a1 build (Build ID: 20210519083222) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20.

• The click and impressions telemetry pings are registered if the "show search suggestions ahead of history" option is unchecked.