Closed
Bug 1711515
Opened 3 years ago
Closed 3 years ago
Remove gProtonDoorhangers, gProtonDoorhangersEnabled, and gProtonAppMenuEnabled from various jsms and other frontend (non-test) code
Categories
(Firefox :: Toolbars and Customization, task, P3)
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: Gijs, Assigned: masterwayz)
References
Details
(Whiteboard: [proton-cleanups])
Attachments
(1 file)
(As noted in bug 1709425, we should not land a patch for this before May 20th. A patch for bug 1711500 will need to land first.)
All of these checks are redundant with proton enabled by default. We should remove the checks, and remove code that only runs if these getters return false.
We should leave gProtonDoorhangers as it's declared in the browser window which is shared, but can remove the other getters declared in jsms here.
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1770
|
||
Updated•3 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Severity: -- → N/A
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → michelle
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8ea44a4cdd0d Remove gProtonDoorhangers, gProtonDoorhangersEnabled, and gProtonAppMenuEnabled from various jsms and other frontend (non-test) code r=Gijs
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•