1711533 - Replace use of getMostRecentBrowserWindow() in mailnews

Status: UNCONFIRMED

(MailNews Core :: General, defect)

Description

[José M. Muñoz]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36

Steps to reproduce:

From bug 1710275 comment #11.

getMostRecentWindow("mail:3pane", ...) should be used like in about 50 other places throughout C-C. getMostRecentBrowserWindow() doesn't seem to be the right function, it has "browser" in its name and it calls getMostRecentWindow("navigator:browser", ...) first and then via a conditional compile for Thunderbird calls getMostRecentWindow("mail:3pane", ...) anyway. The conditional code was introduced in bug 1608894 for certificate handling, but it could be removed at some stage.

Comment 1

[José M. Muñoz]

Attachment: 1711533-GetMostRecentBrowserWindow.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9222220 [details] [diff] [review]
1711533-GetMostRecentBrowserWindow.patch

Review of attachment 9222220 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know... I tend to think what we have is preferable, and we could change the other exiting usage instead. The name is not 100% ideal but it *is* the window where we have what corresponds to a browser.

Comment 3

[José M. Muñoz]

It's not just the name, the function looks for another window first:
https://searchfox.org/mozilla-central/rev/048146721b3c1a568257afb4325c7a8d94334e2d/xpfe/appshell/nsWindowMediator.cpp#236
It's surprising that what was implemented as a hack for bug 1608894 should now become mainstream usage. For mainstream use, the M-C function would need to change not to try "navigator:browser" first. Until you have a clear concept of how you want to proceed, this should go ahead.