[macOS] Row labels in about:support (first column) are illegible (white-on-white text) in macOS high contrast mode
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | verified |
firefox90 | --- | verified |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: access, regression, Whiteboard: [proton-aboutpages] [priority:2c] [proton-uplift])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1711258 +++
Note
This issue doens't reproduce when "Display contrast" is set to Normal (default)
Affected versions
- Firefox 89 beta 12
- latest Nightly 90.0a1 2021-05-14
Affected platforms
- macOSX 10.15, macOSX 11.4 beta
Prerequisites
- Set system theme to Light
- Go to System Preferences - Accessibility and select "Increase contrast" option, then move the cursor one level to the right for "Display contrast" item
Steps to reproduce
- Open Firefox and set the theme to Default or Light
- Go to about:Support and other about:pages
Expected result
- Every element from about: pages is legible and has enough contrast.
Actual result
The left side of about:support table is not visible
Regression range
- Not a regression, introduced with Proton
Additional notes
- Also reproducible when system theme is Dark and Firefox and Firefox is set to Light theme
Assignee | ||
Comment 1•4 years ago
|
||
Attachment 9222143 [details] is a screenshot of what happens here.
:phorea noted in bug 1711258 that there's no regression range. As far as I can tell there is one for the about:support issue, which was fine in the April 9th nightly, when bug 1700109 (enabling proton by default) landed on April 8th. I think the about:support case regressed with bug 1705133.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Set release status flags based on info from the regressing bug 1705133
Comment 5•4 years ago
|
||
bugherder |
Comment 6•4 years ago
|
||
Can we please uplift to Beta 89?
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9222290 [details]
Bug 1711580 - use CSS variable with a system colour for table header cell foreground colours to fix high contrast support on macOS, r?mstriemer
Beta/Release Uplift Approval Request
- User impact if declined: Missing text in high contrast mode on macOS
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minimal CSS changes that only affect the (row) header cells in about: page tables.
- String changes made/needed: nope
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9222290 [details]
Bug 1711580 - use CSS variable with a system colour for table header cell foreground colours to fix high contrast support on macOS, r?mstriemer
Approved for 89 beta 15, thanks.
Comment 9•4 years ago
|
||
bugherder uplift |
Comment 10•4 years ago
|
||
Verified fixed on Nightly 90.0a1 2021-05-19 under macOS 10.15.7 and 11.4 Beta.
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Verified fixed using Firefox 89 beta 15, OSX 11.4 beta.
Updated•2 years ago
|
Description
•