Closed Bug 1711603 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29023 - [video-rvfc] Fix src switch after 1 frame issue

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29023 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29023
Details from upstream follow.

b'Thomas Guilbert <tguilbert@chromium.org>' wrote:

[video-rvfc] Fix src switch after 1 frame issue

Since we don't reset |last_presented_frame_| when switching sources on
a video element, if we update video.src from the first rVFC callback,
the first frame of the src will appear to be "stale". This is because
its |presented_frames| matches |last_presented_frames_| (with a value of
1, but it could technically happen with any number). This results in the
rVFC callback never running, and is especially easy to run into when
writing tests, which will time out.

This CL fixes the issue by clearing |last_presented_frame_| when the
video element's media player is cleared.

It also adds a WPT that switches between two video sources.

Bug: 1201211
Change-Id: I80519c1b19adcbb97ebcd94202e7df1df685d240
Reviewed-on: https://chromium-review.googlesource.com/2901601
WPT-Export-Revision: 52c5826cf698f8cb6b6805427645f51143298ee3

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL : 5

Chrome

PASS : 4
TIMEOUT: 2

Safari

OK : 1
FAIL : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/video-rvfc/request-video-frame-callback.html
Test we can register a video.rVFC callback.: FAIL (Chrome: PASS, Safari: FAIL)
Test video.rVFC callbacks run before window.rAF callbacks.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can cancel a video.rVFC request.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid calls to the video.rVFC API.: FAIL (Chrome: PASS, Safari: FAIL)
Test video.rVFC does not stop when switching sources.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75bfde713456
[wpt PR 29023] - [video-rvfc] Fix src switch after 1 frame issue, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ae7a9178b861
[wpt PR 29023] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/75bfde713456
https://hg.mozilla.org/mozilla-central/rev/ae7a9178b861

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.