Closed
Bug 1711627
Opened 3 years ago
Closed 3 years ago
Avoid xptdata.h being (indirectly) included so much
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•3 years ago
|
||
cf. bug 1710755, touching idl files regenerates xptdata.cpp and
xptdata.h, and the latter currently triggers tons of things to be
rebuilt because xptdata.h is included from xptinfo.h, which is directly
or indirectly included in many other places.
But there's only one thing defined in xptdata.h: nsXPTInterface, and
there's actually only one place that actively uses it:
StaticComponents.cpp.in, via a function defined in xptinfo.h.
Inlining that function into its sole caller allows to only include
xptdata.h from StaticComponents.cpp.in.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/51a187c21494 Avoid xptdata.h being (indirectly) included so much. r=xpcom-reviewers,nika
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•