Closed Bug 1711810 Opened 4 years ago Closed 2 years ago

[wpt-sync] Sync PR 29036 - Refactored AnimationEffect and Timing to provide CalculatedTiming values

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29036 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29036
Details from upstream follow.

b'Jordan Taylor <jortaylo@microsoft.com>' wrote:

Refactored AnimationEffect and Timing to provide CalculatedTiming values

An upcoming change to integrate progress based timelines requires some
tweaks to AnimationEffect to provide public accesss to its
CalculatedTiming member variable. In order for that calculated timing
object to contain the expected values a refactor of CalculateTiming()
was needed.

Now instead of consumers using AnimationEffect::SpecifiedTiming(), they
now use AnimationEffect::CalculatedTiming() unless the needed value is
not calculated (e.g. iteration_count) in which case SpecifiedTiming() is
still used.

Removed a few internal functions in Timing that were no longer necessary
since their values are now cached.

Change-Id: Iaad5610ce080bb405a42944e90dd841f124904f4
Reviewed-on: https://chromium-review.googlesource.com/2904895
WPT-Export-Revision: a4c3d8687f19423cec0588a69828d2de488e73fb

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.