1711836 - [gcc 11] error: 'char* __builtin_strncpy(char*, const char*, long unsigned int)' specified bound 4097 equals destination size

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Mike Hommey [:glandium]]

[task 2021-05-19T04:12:39.952Z] 04:12:39     INFO -  In file included from /builds/worker/fetches/sysroot/usr/include/string.h:640,
[task 2021-05-19T04:12:39.952Z] 04:12:39     INFO -                   from /builds/worker/workspace/obj-build/dist/system_wrappers/string.h:3,
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -                   from /builds/worker/checkouts/gecko/ipc/chromium/src/base/basictypes.h:12,
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -                   from /builds/worker/checkouts/gecko/ipc/chromium/src/base/platform_thread.h:14,
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -                   from /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBroker.h:12,
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -                   from /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBroker.cpp:7,
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -                   from Unified_cpp_linux_broker0.cpp:2:
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -  In function 'char* strncpy(char*, const char*, size_t)',
[task 2021-05-19T04:12:39.956Z] 04:12:39     INFO -      inlined from 'virtual void mozilla::SandboxBroker::ThreadMain()' at /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBroker.cpp:741:14:
[task 2021-05-19T04:12:39.956Z] 04:12:39    ERROR -  /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:34: error: 'char* __builtin_strncpy(char*, const char*, long unsigned int)' specified bound 4097 equals destination size [-Werror=stringop-truncation]
[task 2021-05-19T04:12:39.957Z] 04:12:39     INFO -    120 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T04:12:39.957Z] 04:12:39     INFO -        |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T04:12:39.957Z] 04:12:39     INFO -  cc1plus: all warnings being treated as errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1711836 - Fix GCC warning about the use of strncpy in SandboxBroker::ThreadMain.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f45b115e0b80
Fix GCC warning about the use of strncpy in SandboxBroker::ThreadMain. r=jld

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f45b115e0b80